From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57743)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1V6Jb2-0003MV-9Y
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 08:09:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1V6Jax-0003Ea-D2
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 08:09:08 -0400
Message-ID: <51FF95DC.3050500@siemens.com>
Date: Mon, 05 Aug 2013 14:09:00 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <51F79CD8.7070807@siemens.com>
	<1375464135-29543-1-git-send-email-afaerber@suse.de>
	<51FF952F.3060307@suse.de>
In-Reply-To: <51FF952F.3060307@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error
	handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org

On 2013-08-05 14:06, Andreas F=C3=A4rber wrote:
> Am 02.08.2013 19:22, schrieb Andreas F=C3=A4rber:
>> Error **errp argument is not for emitting warnings, it means an error
>> has occurred and the caller should not make any assumptions about the
>> state of other return values (unless otherwise documented).
>>
>> Therefore cpu_x86_create() must unref the new X86CPU itself, and
>> pc_new_cpu() must check for an Error rather than NULL return value.
>>
>> While at it, clean up a superfluous NULL check.
>>
>> Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
>> Cc: qemu-stable@nongnu.org
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>=20
> Ping! Jan, does this address your concerns / use cases?
> -rc2 is on Wednesday.

Yes, thanks, this looks good.

Jan

--=20
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux