From: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, qemu-stable@nongnu.org,
qemu-devel@nongnu.org, Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>,
Laszlo Ersek <lersek@redhat.com>, Brad <brad@comstyle.com>
Subject: [Qemu-devel] PING for-1.6 Re: [PATCH v3] semaphore: fix a hangup problem under load on NetBSD hosts.
Date: Mon, 05 Aug 2013 18:22:01 +0200 [thread overview]
Message-ID: <51FFD129.4000008@redhat.com> (raw)
In-Reply-To: <51FAE229.7080708@redhat.com>
On 08/02/2013 12:33 AM, Paolo Bonzini wrote:
> On 08/01/2013 05:24 AM, Brad wrote:
>> On 03/07/13 5:41 AM, Laszlo Ersek wrote:
>>> On 07/03/13 10:58, Izumi Tsutsui wrote:
>>>> Fix following bugs in "fallback implementation of counting semaphores
>>>> with mutex+condvar" added in c166cb72f1676855816340666c3b618beef4b976:
>>>> - waiting threads are not restarted properly if more than one threads
>>>> are waiting unblock signals in qemu_sem_timedwait()
>>>> - possible missing pthread_cond_signal(3) calls when waiting threads
>>>> are returned by ETIMEDOUT
>>>> - fix an uninitialized variable
>>>> The problem is analyzed by and fix is provided by Noriyuki Soda.
>>>>
>>>> Also put additional cleanup suggested by Laszlo Ersek:
>>>> - make QemuSemaphore.count unsigned (it won't be negative)
>>>> - check a return value of in pthread_cond_wait() in qemu_sem_wait()
>>>>
>>>> Signed-off-by: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
>>>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>>> ---
>>>>
>>>> v3:
>>>> - fix a missed assignment and actually check a retval of
>>>> pthread_cond_wait()
>>>
>>> Compared v3 against v2.
>>>
>>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>>
>>> Laszlo
>>
>> This patch seems to have been dropped.
>
> CCing Anthony and qemu-stable.
And bumping priority further.
Paolo
next prev parent reply other threads:[~2013-08-05 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 8:58 [Qemu-devel] [PATCH v3] semaphore: fix a hangup problem under load on NetBSD hosts Izumi Tsutsui
2013-07-03 9:41 ` Laszlo Ersek
2013-08-01 3:24 ` Brad
2013-08-01 22:33 ` Paolo Bonzini
2013-08-05 16:22 ` Paolo Bonzini [this message]
2013-08-14 16:29 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FFD129.4000008@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=brad@comstyle.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=tsutsui@ceres.dti.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).