From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6NXy-0001pW-Bz for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:22:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6NXs-0001Ic-HR for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:22:14 -0400 Sender: Paolo Bonzini Message-ID: <51FFD129.4000008@redhat.com> Date: Mon, 05 Aug 2013 18:22:01 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1372841894-10634-1-git-send-email-tsutsui@ceres.dti.ne.jp> <51D3F1C2.5050609@redhat.com> <51F9D506.9040909@comstyle.com> <51FAE229.7080708@redhat.com> In-Reply-To: <51FAE229.7080708@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] PING for-1.6 Re: [PATCH v3] semaphore: fix a hangup problem under load on NetBSD hosts. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aliguori@us.ibm.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, Izumi Tsutsui , Laszlo Ersek , Brad On 08/02/2013 12:33 AM, Paolo Bonzini wrote: > On 08/01/2013 05:24 AM, Brad wrote: >> On 03/07/13 5:41 AM, Laszlo Ersek wrote: >>> On 07/03/13 10:58, Izumi Tsutsui wrote: >>>> Fix following bugs in "fallback implementation of counting semaphores >>>> with mutex+condvar" added in c166cb72f1676855816340666c3b618beef4b976: >>>> - waiting threads are not restarted properly if more than one threads >>>> are waiting unblock signals in qemu_sem_timedwait() >>>> - possible missing pthread_cond_signal(3) calls when waiting threads >>>> are returned by ETIMEDOUT >>>> - fix an uninitialized variable >>>> The problem is analyzed by and fix is provided by Noriyuki Soda. >>>> >>>> Also put additional cleanup suggested by Laszlo Ersek: >>>> - make QemuSemaphore.count unsigned (it won't be negative) >>>> - check a return value of in pthread_cond_wait() in qemu_sem_wait() >>>> >>>> Signed-off-by: Izumi Tsutsui >>>> Reviewed-by: Laszlo Ersek >>>> --- >>>> >>>> v3: >>>> - fix a missed assignment and actually check a retval of >>>> pthread_cond_wait() >>> >>> Compared v3 against v2. >>> >>> Reviewed-by: Laszlo Ersek >>> >>> Laszlo >> >> This patch seems to have been dropped. > > CCing Anthony and qemu-stable. And bumping priority further. Paolo