From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40245)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V6NYC-0002Cu-Ly
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:22:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V6NY6-0001Na-LA
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:22:28 -0400
Message-ID: <51FFD13A.3000800@suse.de>
Date: Mon, 05 Aug 2013 18:22:18 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1375713401-24848-1-git-send-email-afaerber@suse.de>
	<1375713401-24848-3-git-send-email-afaerber@suse.de>
	<51FFB98E.4020207@redhat.com>
In-Reply-To: <51FFB98E.4020207@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.6 v2 2/2] pci-bridge: Move common
 class initializations to base type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org

Am 05.08.2013 16:41, schrieb Paolo Bonzini:
> On 08/05/2013 04:36 PM, Andreas F=C3=A4rber wrote:
>> Set PCIDeviceClass::is_bridge as well as PCIDeviceClass::config_write(=
),
>> PCIDeviceClass::exit() and DeviceClass::reset() defaults directly for
>> TYPE_PCI_BRIDGE (complements f055e96bd4311d287c0e03faec02a1bdbc351925)=
.
>>
>> This avoids another pci_bridge_config_write() missing somewhere, unles=
s
>> explicitly overridden.
>>
>> Reported-by: Gerd Hoffmann <kraxel@redhat.com>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>=20
> Why for 1.6?

This is The Real Fix. We could squash it as one patch, but then we can't
backport it.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg