From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44493)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1V6No3-0003dv-Ph
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:39:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1V6Nnv-0007ZB-D5
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:38:51 -0400
Received: from mail-gh0-x229.google.com ([2607:f8b0:4002:c05::229]:34855)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1V6Nnv-0007Z1-4r
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:38:43 -0400
Received: by mail-gh0-f169.google.com with SMTP id r1so1319420ghr.28
	for <qemu-devel@nongnu.org>; Mon, 05 Aug 2013 09:38:42 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51FFD50C.4070209@twiddle.net>
Date: Mon, 05 Aug 2013 06:38:36 -1000
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1375700771-21665-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1375700771-21665-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] target-arm: Implement 'int' loglevel
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org

On 08/05/2013 01:06 AM, Peter Maydell wrote:
> +        const char *exc = NULL;
> +
> +        if (idx >= 0 && idx < ARRAY_SIZE(excnames)) {
> +            exc = excnames[idx];
> +        }
> +        if (!exc) {
> +            exc = "unknown";
> +        }

Silly test for null here.

  const char *exc = "unknown";
  if (...) {
     exc = excnames[idx];
  }

Otherwise the patch looks good.


r~