From: "Andreas Färber" <afaerber@suse.de>
To: Alberto Garcia <agarcia@igalia.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH qom-next for-next 1/6] ipack: Convert to QOM realize
Date: Mon, 05 Aug 2013 19:46:25 +0200 [thread overview]
Message-ID: <51FFE4F1.1080205@suse.de> (raw)
In-Reply-To: <20130805151621.GA27253@igalia.com>
Am 05.08.2013 17:16, schrieb Alberto Garcia:
> On Fri, Aug 02, 2013 at 11:16:56PM +0200, Andreas Färber wrote:
>
>> +#define IPOCTAL_GET_PARENT_CLASS(obj) \
>> + OBJECT_GET_PARENT_CLASS(obj, TYPE_IPOCTAL)
>
> Hey, I cannot make it compile with the latest master:
>
> hw/char/ipoctal232.c: In function ‘ipoctal_realize’:
> hw/char/ipoctal232.c:544:5: error: implicit declaration of function ‘OBJECT_GET_PARENT_CLASS’ [-Werror=implicit-function-declaration]
> hw/char/ipoctal232.c:544:5: error: nested extern declaration of ‘OBJECT_GET_PARENT_CLASS’ [-Werror=nested-externs]
Sorry, forgot to mention that in the cover letter: The branch linked to
has one patch before this series introducing that macro. It's on the
list as part of the virtio conversion series:
http://patchwork.ozlabs.org/patch/263863/
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-08-05 17:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 21:16 [Qemu-devel] [PATCH qom-next for-next 0/6] QOM realize for IndustryPack Andreas Färber
2013-08-02 21:16 ` [Qemu-devel] [PATCH qom-next for-next 1/6] ipack: Convert to QOM realize Andreas Färber
2013-08-05 15:16 ` Alberto Garcia
2013-08-05 17:46 ` Andreas Färber [this message]
2013-08-02 21:16 ` [Qemu-devel] [PATCH qom-next for-next 2/6] ipack: QOM parent field cleanup for IPackBus Andreas Färber
2013-08-02 21:16 ` [Qemu-devel] [PATCH qom-next for-next 3/6] ipack: QOM parent field cleanup for IPackDevice Andreas Färber
2013-08-02 21:16 ` [Qemu-devel] [PATCH qom-next for-next 4/6] ipack: Simplify VMSTATE_IPACK_DEVICE() macro Andreas Färber
2013-08-02 21:17 ` [Qemu-devel] [PATCH qom-next for-next 5/6] ipoctal232: QOM parent field cleanup Andreas Färber
2013-08-02 21:17 ` [Qemu-devel] [PATCH qom-next for-next 6/6] ipack: Move IndustryPack out of hw/char/ Andreas Färber
2013-08-06 8:48 ` [Qemu-devel] [PATCH qom-next for-next 0/6] QOM realize for IndustryPack Alberto Garcia
2014-02-08 19:58 ` Andreas Färber
2014-02-08 23:31 ` Paolo Bonzini
2014-02-09 21:31 ` Paolo Bonzini
2014-02-09 21:46 ` Alberto Garcia
2014-02-09 22:12 ` Andreas Färber
2014-02-09 18:17 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FFE4F1.1080205@suse.de \
--to=afaerber@suse.de \
--cc=agarcia@igalia.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).