qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Brad Smith <brad@comstyle.com>
To: Thomas Huth <thuth@redhat.com>,
	David CARLIER <devnexen@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH] util: qemu_get_thread_id for OpenBSD
Date: Wed, 15 Jul 2020 03:39:58 -0400	[thread overview]
Message-ID: <51a660f2-2241-d27f-afd5-a02ce5bd0e73@comstyle.com> (raw)
In-Reply-To: <631dad16-66cd-3f7b-90bc-969c52d29aa1@redhat.com>

On 7/15/2020 12:54 AM, Thomas Huth wrote:
> On 14/07/2020 23.26, David CARLIER wrote:
>>  From 9c7f54c67d40fae0174ba795fbaad829cd59c264 Mon Sep 17 00:00:00 2001
>> From: David Carlier <devnexen@gmail.com>
>> Date: Tue, 14 Jul 2020 23:23:55 +0100
>> Subject: [PATCH] util: qemu_get_thread_id implementation for OpenBSD.
>>
>> ussage of getthrid syscall.
>>
>> Signed-off-by: David Carlier <devnexen@gmail.com>
>> ---
>>   util/oslib-posix.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
>> index 72907d4d7f..b4f7de83c8 100644
>> --- a/util/oslib-posix.c
>> +++ b/util/oslib-posix.c
>> @@ -100,6 +100,8 @@ int qemu_get_thread_id(void)
>>       return (int)tid;
>>   #elif defined(__NetBSD__)
>>       return _lwp_self();
>> +#elif defined(__OpenBSD__)
>> +    return getthrid();
>>   #else
>>       return getpid();
>>   #endif
>>
>   Brad,
>
> since you're listed as OpenBSD maintainer, could you please review above
> patch?

Thank you David and Thomas.

Reviewed-by: Brad Smith <brad@comstyle.com>



  reply	other threads:[~2020-07-15  7:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 21:26 [PATCH] util: qemu_get_thread_id for OpenBSD David CARLIER
2020-07-15  4:54 ` Thomas Huth
2020-07-15  7:39   ` Brad Smith [this message]
2020-07-16 14:39     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51a660f2-2241-d27f-afd5-a02ce5bd0e73@comstyle.com \
    --to=brad@comstyle.com \
    --cc=devnexen@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).