From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
philmd@redhat.com, slp@redhat.com,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH v2 8/8] pc: stubify x86 iommu
Date: Tue, 7 Jan 2020 15:59:23 +0100 [thread overview]
Message-ID: <51be9ce0-383f-2bf1-fda6-c6d9b09f3169@redhat.com> (raw)
In-Reply-To: <fae3437d-36c9-73bf-05a5-294cbffb9fad@redhat.com>
On 07/01/2020 15.26, Thomas Huth wrote:
> On 12/12/2019 18.29, Paolo Bonzini wrote:
>> Allow building microvm without x86-iommu.c and in turn hw/i386/pc.h.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> hw/i386/Kconfig | 6 ++++++
>> hw/i386/Makefile.objs | 3 ++-
>> hw/i386/x86-iommu-stub.c | 34 ++++++++++++++++++++++++++++++++++
>> 3 files changed, 42 insertions(+), 1 deletions(-)
>> create mode 100644 hw/i386/x86-iommu-stub.c
>
> I just ran into this strange Travis build issue:
>
> https://travis-ci.com/huth/qemu/jobs/273007378#L3509
>
> ... I think it might be related to this patch?
>
> CONFIG_Q35 only does "imply AMD_IOMMU", so when compiling with
> "--without-default-devices", x86-iommu.c is not used... Do
> x86_iommu_ir_supported() and x86_iommu_get_type() need to be added to
> the x86-iommu-stub.c file?
FWIW, I just found Phil's patch which should fix this issue:
https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg00959.html
Thomas
prev parent reply other threads:[~2020-01-07 15:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 17:29 [PATCH v2 0/8] x86: allow building without PC machine types Paolo Bonzini
2019-12-12 17:29 ` [PATCH v2 1/8] i386: conditionally compile more files Paolo Bonzini
2019-12-12 17:29 ` [PATCH v2 2/8] fw_cfg: allow building without other devices Paolo Bonzini
2019-12-12 17:29 ` [PATCH v2 3/8] hw: replace hw/i386/pc.h with a header just for the i8259 Paolo Bonzini
2019-12-12 19:03 ` Philippe Mathieu-Daudé
2019-12-12 20:05 ` Paolo Bonzini
2019-12-13 9:43 ` Philippe Mathieu-Daudé
2019-12-13 14:56 ` Paolo Bonzini
2019-12-12 17:29 ` [PATCH v2 4/8] pci-stub: add more MSI functions Paolo Bonzini
2019-12-12 19:49 ` Philippe Mathieu-Daudé
2019-12-12 17:29 ` [PATCH v2 5/8] x86: move SMM property to X86MachineState Paolo Bonzini
2019-12-13 14:50 ` Philippe Mathieu-Daudé
2019-12-12 17:29 ` [PATCH v2 6/8] x86: move more x86-generic functions out of PC files Paolo Bonzini
2020-01-08 8:03 ` Gerd Hoffmann
2020-01-08 8:19 ` Paolo Bonzini
2019-12-12 17:29 ` [PATCH v2 7/8] acpi: move PC stubs out of stubs/ Paolo Bonzini
2019-12-12 17:29 ` [PATCH v2 8/8] pc: stubify x86 iommu Paolo Bonzini
2020-01-07 14:26 ` Thomas Huth
2020-01-07 14:59 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51be9ce0-383f-2bf1-fda6-c6d9b09f3169@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).