From: Richard Henderson <richard.henderson@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, philmd@linaro.org, maobibo@loongson.cn,
yangxiaojuan@loongson.cn
Subject: Re: [PATCH] target/loongarch: Fix LD/ST{LE/GT} instructions get wrong CSR_ERA and CSR_BADV
Date: Mon, 15 May 2023 06:11:25 -0700 [thread overview]
Message-ID: <51c1ca8b-97e9-acfe-184b-fa5c26f8fd0c@linaro.org> (raw)
In-Reply-To: <20230515130042.2719712-1-gaosong@loongson.cn>
On 5/15/23 06:00, Song Gao wrote:
> 1.helper_asrtle_d/helper_asrtgt_d need use GETPC() to get PC;
> 2 LD/ST{LE/GT} need set CSR_BADV = gpr[rj];
> 3 ASRTLE.D/ASRTGT.D also write CSR_BADV, but this value is random
> and has no reference value.
>
> Signed-off-by: Song Gao<gaosong@loongson.cn>
> ---
> target/loongarch/cpu.c | 2 +-
> target/loongarch/op_helper.c | 6 ++++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2023-05-15 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 13:00 [PATCH] target/loongarch: Fix LD/ST{LE/GT} instructions get wrong CSR_ERA and CSR_BADV Song Gao
2023-05-15 13:11 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51c1ca8b-97e9-acfe-184b-fa5c26f8fd0c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gaosong@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).