From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 4/7] nvic: Don't apply group priority mask to negative priorities
Date: Wed, 13 Sep 2017 08:58:12 -0700 [thread overview]
Message-ID: <51e485a4-6557-717c-fa18-7e46033f8f73@linaro.org> (raw)
In-Reply-To: <1505137930-13255-5-git-send-email-peter.maydell@linaro.org>
On 09/11/2017 06:52 AM, Peter Maydell wrote:
> In several places we were unconditionally applying the
> nvic_gprio_mask() to a priority value. This is incorrect
> if the priority is one of the fixed negative priority
> values (for NMI and HardFault), so don't do it.
>
> This bug would have caused both NMI and HardFault to be
> considered as the same priority and so NMI wouldn't
> correctly preempt HardFault.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/intc/armv7m_nvic.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2017-09-13 15:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 13:52 [Qemu-devel] [PATCH 0/7] ARMv8M: some bugfixes and prep. cleanup Peter Maydell
2017-09-11 13:52 ` [Qemu-devel] [PATCH 1/7] target/arm: Use M_REG_NUM_BANKS rather than hardcoding 2 Peter Maydell
2017-09-11 14:59 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-09-11 17:32 ` Alistair Francis
2017-09-11 13:52 ` [Qemu-devel] [PATCH 2/7] target/arm: Clear exclusive monitor on v7M reset, exception entry/exit Peter Maydell
2017-09-11 17:33 ` Alistair Francis
2017-09-13 15:55 ` Richard Henderson
2017-09-11 13:52 ` [Qemu-devel] [PATCH 3/7] target/arm: Get PRECISERR and IBUSERR the right way round Peter Maydell
2017-09-11 17:38 ` Alistair Francis
2017-09-13 15:57 ` Richard Henderson
2017-09-11 13:52 ` [Qemu-devel] [PATCH 4/7] nvic: Don't apply group priority mask to negative priorities Peter Maydell
2017-09-13 15:58 ` Richard Henderson [this message]
2017-09-11 13:52 ` [Qemu-devel] [PATCH 5/7] target/arm: Remove unnecessary '| 0xf0000000' from do_v7m_exception_exit() Peter Maydell
2017-09-11 17:41 ` Alistair Francis
2017-09-13 16:36 ` Richard Henderson
2017-09-11 13:52 ` [Qemu-devel] [PATCH 6/7] target/arm: Add and use defines for EXCRET constants Peter Maydell
2017-09-11 17:43 ` Alistair Francis
2017-09-11 13:52 ` [Qemu-devel] [PATCH 7/7] target/arm: Rename 'type' to 'excret' in do_v7m_exception_exit() Peter Maydell
2017-09-11 15:03 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-09-11 17:45 ` Alistair Francis
2017-09-13 16:41 ` [Qemu-devel] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51e485a4-6557-717c-fa18-7e46033f8f73@linaro.org \
--to=richard.henderson@linaro.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).