From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60705)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1V6bkZ-0000FO-4p
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 03:32:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1V6bkQ-0007gT-Nm
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 03:32:11 -0400
Received: from mail-ee0-x235.google.com ([2a00:1450:4013:c00::235]:44664)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1V6bkQ-0007gI-HP
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 03:32:02 -0400
Received: by mail-ee0-f53.google.com with SMTP id b15so26366eek.12
	for <qemu-devel@nongnu.org>; Tue, 06 Aug 2013 00:32:01 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5200A66C.7090707@redhat.com>
Date: Tue, 06 Aug 2013 09:31:56 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1375688006-16780-1-git-send-email-pingfank@linux.vnet.ibm.com>
	<1375688006-16780-3-git-send-email-pingfank@linux.vnet.ibm.com>
	<771358257.9598648.1375709344876.JavaMail.root@redhat.com>
	<CAJnKYQmi5Jb4MCv67+1WpWG4_y5oPC0nqAZJKZs=3+u10whTDw@mail.gmail.com>
In-Reply-To: <CAJnKYQmi5Jb4MCv67+1WpWG4_y5oPC0nqAZJKZs=3+u10whTDw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] timer: protect timers_state's clock
	with seqlock
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liu ping fan <qemulist@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Alex Bligh <alex@alex.org.uk>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>

On 08/06/2013 07:58 AM, liu ping fan wrote:
> On Mon, Aug 5, 2013 at 9:29 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>>> In kvm mode, vm_clock may be read outside BQL.
>>
>> Not just in KVM mode (we will be able to use dataplane with TCG sooner
>> or later), actually.
>>
> Oh. But this patch does not fix cpu_get_icount()'s thread-safe issue.
> So currently, could I just change the commit log instead of fixing it?

Yeah, icount is a bit more complicated.  Just change the commit log.

Paolo