From: "Andreas Färber" <afaerber@suse.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 for-1.6] mips: revert commit b332d24a8e1290954029814d09156b06ede358e2
Date: Tue, 06 Aug 2013 13:35:12 +0200 [thread overview]
Message-ID: <5200DF70.3070600@suse.de> (raw)
In-Reply-To: <1375787317-31359-1-git-send-email-aurelien@aurel32.net>
Am 06.08.2013 13:08, schrieb Aurelien Jarno:
> Now that this code path is not triggered anymore during the tests,
> revert commit b332d24a8e1290954029814d09156b06ede358e2. Booting a MIPS
> target without kernel nor bios doesn't really make sense. At the same
> time replace fprintf(stderr, ...) by error_report().
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> hw/mips/mips_fulong2e.c | 4 +++-
> hw/mips/mips_jazz.c | 5 +++--
> hw/mips/mips_malta.c | 7 ++++---
> hw/mips/mips_mipssim.c | 7 ++++---
> 4 files changed, 14 insertions(+), 9 deletions(-)
>
> v1 -> v2: replace fprintf(stderr, ...) by error_report()
If you drop the two remaining \n then feel free to commit with my
Reviewed-by.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-08-06 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 11:08 [Qemu-devel] [PATCH v2 for-1.6] mips: revert commit b332d24a8e1290954029814d09156b06ede358e2 Aurelien Jarno
2013-08-06 11:35 ` Andreas Färber [this message]
2013-08-08 21:13 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5200DF70.3070600@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).