From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59944)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V6fXv-0004UO-D3
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 07:35:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V6fXp-0002Nm-F9
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 07:35:23 -0400
Received: from cantor2.suse.de ([195.135.220.15]:38550 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V6fXp-0002Na-9E
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 07:35:17 -0400
Message-ID: <5200DF70.3070600@suse.de>
Date: Tue, 06 Aug 2013 13:35:12 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1375787317-31359-1-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1375787317-31359-1-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 for-1.6] mips: revert commit
	b332d24a8e1290954029814d09156b06ede358e2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Am 06.08.2013 13:08, schrieb Aurelien Jarno:
> Now that this code path is not triggered anymore during the tests,
> revert commit b332d24a8e1290954029814d09156b06ede358e2. Booting a MIPS
> target without kernel nor bios doesn't really make sense. At the same
> time replace fprintf(stderr, ...) by error_report().
>=20
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  hw/mips/mips_fulong2e.c |    4 +++-
>  hw/mips/mips_jazz.c     |    5 +++--
>  hw/mips/mips_malta.c    |    7 ++++---
>  hw/mips/mips_mipssim.c  |    7 ++++---
>  4 files changed, 14 insertions(+), 9 deletions(-)
>=20
> v1 -> v2: replace fprintf(stderr, ...) by error_report()

If you drop the two remaining \n then feel free to commit with my
Reviewed-by.

Thanks,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg