From: Thomas Huth <thuth@redhat.com>
To: "Inès Varhol" <ines.varhol@telecom-paris.fr>, qemu-devel@nongnu.org
Cc: "Samuel Tardieu" <samuel.tardieu@telecom-paris.fr>,
"Arnaud Minier" <arnaud.minier@telecom-paris.fr>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [RFC 3/3] tests/qtest: Add STM32L4x5 GPIO QTest testcase
Date: Mon, 15 Jan 2024 06:52:58 +0100 [thread overview]
Message-ID: <5200b68d-6b3d-491f-8e51-4a53aca2f3a1@redhat.com> (raw)
In-Reply-To: <20240112170635.303226-4-ines.varhol@telecom-paris.fr>
Hi!
On 12/01/2024 18.05, Inès Varhol wrote:
> Signed-off-by: Arnaud Minier <arnaud.minier@telecom-paris.fr>
> Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
> ---
Maybe add a short patch description (e.g. saying what aspects of the GPIOs
are tested here)?
> diff --git a/tests/qtest/stm32l4x5_gpio-test.c b/tests/qtest/stm32l4x5_gpio-test.c
> new file mode 100644
> index 0000000000..189083bc4f
> --- /dev/null
> +++ b/tests/qtest/stm32l4x5_gpio-test.c
...
> +static void test_idr_reset_value(void)
> +{
> + /*
> + * Check that IDR register as well as other registers
> + * determining its value have the exepcted value
s/exepcted/expected/
> + * GPIOA->IDR value after reset is not identical
> + * to the real one ad Alternate Functions aren't
s/ad/and/ ?
> + * implemented
> + */
With the typos fixed:
Acked-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2024-01-15 5:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 17:05 [RFC 0/3] Add device STM32L4x5 GPIO Inès Varhol
2024-01-12 17:05 ` [RFC 1/3] hw/gpio: Implement " Inès Varhol
2024-01-12 17:05 ` [RFC 2/3] hw/arm: Connect STM32L4x5 GPIO to STM32L4x5 SoC Inès Varhol
2024-01-12 17:05 ` [RFC 3/3] tests/qtest: Add STM32L4x5 GPIO QTest testcase Inès Varhol
2024-01-15 5:52 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5200b68d-6b3d-491f-8e51-4a53aca2f3a1@redhat.com \
--to=thuth@redhat.com \
--cc=alistair@alistair23.me \
--cc=arnaud.minier@telecom-paris.fr \
--cc=ines.varhol@telecom-paris.fr \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.tardieu@telecom-paris.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).