From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37210)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1V6rab-0001af-AS
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 20:26:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1V6raa-0005wt-9f
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 20:26:57 -0400
Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:41838
	helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1V6raa-0005vG-4P
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 20:26:56 -0400
Message-ID: <52019428.2050302@comstyle.com>
Date: Tue, 06 Aug 2013 20:26:16 -0400
From: Brad Smith <brad@comstyle.com>
MIME-Version: 1.0
References: <1375789738-28034-1-git-send-email-stefanha@redhat.com>
In-Reply-To: <1375789738-28034-1-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-1.6] qemu-timer: fix get_clock()
 gettimeofday() fallback #ifdef
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org

On 06/08/13 7:48 AM, Stefan Hajnoczi wrote:
> If CLOCK_MONOTONIC is not defined by system headers we use
> gettimeofday(2).  Apparently this is not used very often since no one
> noticed the #ifdef was actually broken and left the function definition
> unterminated.

Can you show what this supposedly fixes? This code built just fine on
OpenBSD before d05ef160453e98546a4197496dc8a3cb2defac53.

> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   include/qemu/timer.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> index 9dd206c..e3299b8 100644
> --- a/include/qemu/timer.h
> +++ b/include/qemu/timer.h
> @@ -125,8 +125,8 @@ static inline int64_t get_clock(void)
>              changes, so it should be avoided. */
>           return get_clock_realtime();
>       }
> -}
>   #endif
> +}
>
>   void qemu_get_timer(QEMUFile *f, QEMUTimer *ts);
>   void qemu_put_timer(QEMUFile *f, QEMUTimer *ts);
>


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.