* [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx
@ 2013-08-08 8:46 Orit Wasserman
2013-08-08 12:46 ` Eric Blake
2013-08-08 14:50 ` Luiz Capitulino
0 siblings, 2 replies; 5+ messages in thread
From: Orit Wasserman @ 2013-08-08 8:46 UTC (permalink / raw)
To: qemu-devel; +Cc: Orit Wasserman, lcapitulino, armbru, quintela
"ram" is present also when migration completes.
total-time and downtime are no longer part of "ram" data.
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
---
qmp-commands.hx | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 2e59b0d..1d43f4c 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -2626,8 +2626,8 @@ The main json-object contains the following:
- "expected-downtime": only present while migration is active
total amount in ms for downtime that was calculated on
the last bitmap round (json-int)
-- "ram": only present if "status" is "active", it is a json-object with the
- following RAM information:
+- "ram": only present if "status" is "active" or "complete", it is a
+ json-object with the following RAM information:
- "transferred": amount transferred in bytes (json-int)
- "remaining": amount remaining to transfer in bytes (json-int)
- "total": total amount of memory in bytes (json-int)
@@ -2669,12 +2669,12 @@ Examples:
-> { "execute": "query-migrate" }
<- { "return": {
"status": "completed",
+ "total-time":12345,
+ "downtime":12345,
"ram":{
"transferred":123,
"remaining":123,
"total":246,
- "total-time":12345,
- "downtime":12345,
"duplicate":123,
"normal":123,
"normal-bytes":123456
@@ -2693,11 +2693,11 @@ Examples:
<- {
"return":{
"status":"active",
+ "total-time":12345,
"ram":{
"transferred":123,
"remaining":123,
"total":246,
- "total-time":12345,
"expected-downtime":12345,
"duplicate":123,
"normal":123,
@@ -2712,11 +2712,11 @@ Examples:
<- {
"return":{
"status":"active",
+ "total-time":12345,
"ram":{
"total":1057024,
"remaining":1053304,
"transferred":3720,
- "total-time":12345,
"expected-downtime":12345,
"duplicate":123,
"normal":123,
@@ -2736,12 +2736,12 @@ Examples:
<- {
"return":{
"status":"active",
+ "total-time":12345,
"capabilities" : [ { "capability": "xbzrle", "state" : true } ],
"ram":{
"total":1057024,
"remaining":1053304,
"transferred":3720,
- "total-time":12345,
"expected-downtime":12345,
"duplicate":10,
"normal":3333,
--
1.8.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx
2013-08-08 8:46 [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx Orit Wasserman
@ 2013-08-08 12:46 ` Eric Blake
2013-08-08 14:50 ` Luiz Capitulino
1 sibling, 0 replies; 5+ messages in thread
From: Eric Blake @ 2013-08-08 12:46 UTC (permalink / raw)
To: Orit Wasserman; +Cc: armbru, quintela, qemu-devel, lcapitulino
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On 08/08/2013 02:46 AM, Orit Wasserman wrote:
> "ram" is present also when migration completes.
> total-time and downtime are no longer part of "ram" data.
>
> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
> ---
> qmp-commands.hx | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx
2013-08-08 8:46 [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx Orit Wasserman
2013-08-08 12:46 ` Eric Blake
@ 2013-08-08 14:50 ` Luiz Capitulino
2013-08-08 16:47 ` Orit Wasserman
1 sibling, 1 reply; 5+ messages in thread
From: Luiz Capitulino @ 2013-08-08 14:50 UTC (permalink / raw)
To: Orit Wasserman; +Cc: armbru, qemu-devel, quintela
On Thu, 8 Aug 2013 11:46:14 +0300
Orit Wasserman <owasserm@redhat.com> wrote:
> "ram" is present also when migration completes.
> total-time and downtime are no longer part of "ram" data.
expected-downtime has to be moved too, looks good otherwise.
>
> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
> ---
> qmp-commands.hx | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 2e59b0d..1d43f4c 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -2626,8 +2626,8 @@ The main json-object contains the following:
> - "expected-downtime": only present while migration is active
> total amount in ms for downtime that was calculated on
> the last bitmap round (json-int)
> -- "ram": only present if "status" is "active", it is a json-object with the
> - following RAM information:
> +- "ram": only present if "status" is "active" or "complete", it is a
> + json-object with the following RAM information:
> - "transferred": amount transferred in bytes (json-int)
> - "remaining": amount remaining to transfer in bytes (json-int)
> - "total": total amount of memory in bytes (json-int)
> @@ -2669,12 +2669,12 @@ Examples:
> -> { "execute": "query-migrate" }
> <- { "return": {
> "status": "completed",
> + "total-time":12345,
> + "downtime":12345,
> "ram":{
> "transferred":123,
> "remaining":123,
> "total":246,
> - "total-time":12345,
> - "downtime":12345,
> "duplicate":123,
> "normal":123,
> "normal-bytes":123456
> @@ -2693,11 +2693,11 @@ Examples:
> <- {
> "return":{
> "status":"active",
> + "total-time":12345,
> "ram":{
> "transferred":123,
> "remaining":123,
> "total":246,
> - "total-time":12345,
> "expected-downtime":12345,
> "duplicate":123,
> "normal":123,
> @@ -2712,11 +2712,11 @@ Examples:
> <- {
> "return":{
> "status":"active",
> + "total-time":12345,
> "ram":{
> "total":1057024,
> "remaining":1053304,
> "transferred":3720,
> - "total-time":12345,
> "expected-downtime":12345,
> "duplicate":123,
> "normal":123,
> @@ -2736,12 +2736,12 @@ Examples:
> <- {
> "return":{
> "status":"active",
> + "total-time":12345,
> "capabilities" : [ { "capability": "xbzrle", "state" : true } ],
> "ram":{
> "total":1057024,
> "remaining":1053304,
> "transferred":3720,
> - "total-time":12345,
> "expected-downtime":12345,
> "duplicate":10,
> "normal":3333,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx
2013-08-08 14:50 ` Luiz Capitulino
@ 2013-08-08 16:47 ` Orit Wasserman
2013-08-08 16:53 ` Luiz Capitulino
0 siblings, 1 reply; 5+ messages in thread
From: Orit Wasserman @ 2013-08-08 16:47 UTC (permalink / raw)
To: Luiz Capitulino; +Cc: armbru, qemu-devel, quintela
On 08/08/2013 05:50 PM, Luiz Capitulino wrote:
> On Thu, 8 Aug 2013 11:46:14 +0300
> Orit Wasserman <owasserm@redhat.com> wrote:
>
>> "ram" is present also when migration completes.
>> total-time and downtime are no longer part of "ram" data.
>
> expected-downtime has to be moved too, looks good otherwise.
I will fix it in a separate patch.
Orit
>
>>
>> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
>> ---
>> qmp-commands.hx | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/qmp-commands.hx b/qmp-commands.hx
>> index 2e59b0d..1d43f4c 100644
>> --- a/qmp-commands.hx
>> +++ b/qmp-commands.hx
>> @@ -2626,8 +2626,8 @@ The main json-object contains the following:
>> - "expected-downtime": only present while migration is active
>> total amount in ms for downtime that was calculated on
>> the last bitmap round (json-int)
>> -- "ram": only present if "status" is "active", it is a json-object with the
>> - following RAM information:
>> +- "ram": only present if "status" is "active" or "complete", it is a
>> + json-object with the following RAM information:
>> - "transferred": amount transferred in bytes (json-int)
>> - "remaining": amount remaining to transfer in bytes (json-int)
>> - "total": total amount of memory in bytes (json-int)
>> @@ -2669,12 +2669,12 @@ Examples:
>> -> { "execute": "query-migrate" }
>> <- { "return": {
>> "status": "completed",
>> + "total-time":12345,
>> + "downtime":12345,
>> "ram":{
>> "transferred":123,
>> "remaining":123,
>> "total":246,
>> - "total-time":12345,
>> - "downtime":12345,
>> "duplicate":123,
>> "normal":123,
>> "normal-bytes":123456
>> @@ -2693,11 +2693,11 @@ Examples:
>> <- {
>> "return":{
>> "status":"active",
>> + "total-time":12345,
>> "ram":{
>> "transferred":123,
>> "remaining":123,
>> "total":246,
>> - "total-time":12345,
>> "expected-downtime":12345,
>> "duplicate":123,
>> "normal":123,
>> @@ -2712,11 +2712,11 @@ Examples:
>> <- {
>> "return":{
>> "status":"active",
>> + "total-time":12345,
>> "ram":{
>> "total":1057024,
>> "remaining":1053304,
>> "transferred":3720,
>> - "total-time":12345,
>> "expected-downtime":12345,
>> "duplicate":123,
>> "normal":123,
>> @@ -2736,12 +2736,12 @@ Examples:
>> <- {
>> "return":{
>> "status":"active",
>> + "total-time":12345,
>> "capabilities" : [ { "capability": "xbzrle", "state" : true } ],
>> "ram":{
>> "total":1057024,
>> "remaining":1053304,
>> "transferred":3720,
>> - "total-time":12345,
>> "expected-downtime":12345,
>> "duplicate":10,
>> "normal":3333,
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx
2013-08-08 16:47 ` Orit Wasserman
@ 2013-08-08 16:53 ` Luiz Capitulino
0 siblings, 0 replies; 5+ messages in thread
From: Luiz Capitulino @ 2013-08-08 16:53 UTC (permalink / raw)
To: Orit Wasserman; +Cc: armbru, qemu-devel, quintela
On Thu, 08 Aug 2013 19:47:50 +0300
Orit Wasserman <owasserm@redhat.com> wrote:
> On 08/08/2013 05:50 PM, Luiz Capitulino wrote:
> > On Thu, 8 Aug 2013 11:46:14 +0300
> > Orit Wasserman <owasserm@redhat.com> wrote:
> >
> >> "ram" is present also when migration completes.
> >> total-time and downtime are no longer part of "ram" data.
> >
> > expected-downtime has to be moved too, looks good otherwise.
>
> I will fix it in a separate patch.
Why not quickly respin the patch with the instances of the
same problem fixed?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-08-08 16:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-08 8:46 [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx Orit Wasserman
2013-08-08 12:46 ` Eric Blake
2013-08-08 14:50 ` Luiz Capitulino
2013-08-08 16:47 ` Orit Wasserman
2013-08-08 16:53 ` Luiz Capitulino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).