From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7S8K-0002qu-Fp for qemu-devel@nongnu.org; Thu, 08 Aug 2013 11:28:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7S8E-0005cQ-3a for qemu-devel@nongnu.org; Thu, 08 Aug 2013 11:28:12 -0400 Received: from mout.web.de ([212.227.15.3]:61002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7S8D-0005c1-Qr for qemu-devel@nongnu.org; Thu, 08 Aug 2013 11:28:06 -0400 Received: from mchn199C.mchp.siemens.de ([95.157.58.223]) by smtp.web.de (mrweb001) with ESMTPSA (Nemesis) id 0MCqWJ-1VFOUh0MWB-009dul for ; Thu, 08 Aug 2013 17:28:04 +0200 Message-ID: <5203B8FE.5070200@web.de> Date: Thu, 08 Aug 2013 17:27:58 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <51FCBF4E.90605@web.de> <51FCBFD2.3030401@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fiFmXD8HsBbQ02DkQSrPq5Pa5jNCLIoIF" Subject: Re: [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from unsigned regions" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Anthony Liguori , qemu-devel , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fiFmXD8HsBbQ02DkQSrPq5Pa5jNCLIoIF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2013-08-08 17:23, Peter Maydell wrote: > On 3 August 2013 09:31, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71. >> >> The commit was wrong: We only return -1 on invalid accesses, not on >> valid but unbacked ones. This broke various corner cases. >> >> Signed-off-by: Jan Kiszka >=20 > This revert fixes the regression in the 'musicpal' board. >=20 > Presumably these two patches should go into 1.6 since it is > a regression fix... cc'ing Anthony. >=20 > Reviewed-by: Peter Maydell Yes, for 1.6 definitely. Sorry, forgot the proper CCing/tagging. Thanks, Jan --fiFmXD8HsBbQ02DkQSrPq5Pa5jNCLIoIF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlIDuQEACgkQitSsb3rl5xS1iQCfdQ+OC/l11o6y1TWFSKWr+HJY ciMAnij9uLhCnphyO0SwEQtV1I706xx/ =FyoH -----END PGP SIGNATURE----- --fiFmXD8HsBbQ02DkQSrPq5Pa5jNCLIoIF--