From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7j4k-00016y-6O for qemu-devel@nongnu.org; Fri, 09 Aug 2013 05:33:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7j4e-0003my-7X for qemu-devel@nongnu.org; Fri, 09 Aug 2013 05:33:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7j4d-0003mu-W6 for qemu-devel@nongnu.org; Fri, 09 Aug 2013 05:33:32 -0400 Message-ID: <5204B749.1010108@redhat.com> Date: Fri, 09 Aug 2013 11:32:57 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1375943171-1063-1-git-send-email-pingfank@linux.vnet.ibm.com> <1375943171-1063-3-git-send-email-pingfank@linux.vnet.ibm.com> <5204A300.5020405@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 2/5] slirp: make timeout local List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liu ping fan Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , mdroth Il 09/08/2013 10:48, liu ping fan ha scritto: > After patch 3,4, the timeout will be an param for GSource's prepare. > So I think I will set the right timeout value in patch4? No, please do it before (in fact you can extract this patch and the timeout change to a seprate series). Then patch 4 can simply move the timeout logic to the GSource's prepare function. Paolo