From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48092)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7jbH-0000WD-Li
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 06:07:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7jbC-0000sd-MG
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 06:07:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13644)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7jbC-0000sK-8u
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 06:07:10 -0400
Message-ID: <5204BF28.6000800@redhat.com>
Date: Fri, 09 Aug 2013 12:06:32 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1375998147-24292-1-git-send-email-alex@alex.org.uk>
	<1375998147-24292-14-git-send-email-alex@alex.org.uk>
In-Reply-To: <1375998147-24292-14-git-send-email-alex@alex.org.uk>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] [PATCHv8 13/30] aio / timers: Add
	aio_timer_new wrapper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, liu ping fan <qemulist@gmail.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

Il 08/08/2013 23:42, Alex Bligh ha scritto:
> Add aio_timer_new wrapper function.
> 
> Signed-off-by: Alex Bligh <alex@alex.org.uk>
> ---
>  include/block/aio.h |   19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/include/block/aio.h b/include/block/aio.h
> index a13f6e8..bd6f17c 100644
> --- a/include/block/aio.h
> +++ b/include/block/aio.h
> @@ -255,4 +255,23 @@ void qemu_aio_set_fd_handler(int fd,
>                               void *opaque);
>  #endif
>  
> +/**
> + * aio_timer_new:
> + * @ctx: the aio context
> + * @type: the clock type
> + * @scale: the scale
> + * @cb: the callback to call on timer expiry
> + * @opaque: the opaque pointer to pass to the callback
> + *
> + * Generate a new timer attached to the context @ctx.
> + *
> + * Returns: a pointer to the new timer
> + */
> +static inline QEMUTimer *aio_timer_new(AioContext *ctx, QEMUClockType type,
> +                                       int scale,
> +                                       QEMUTimerCB *cb, void *opaque)
> +{
> +    return timer_new(ctx->tlg[type], scale, cb, opaque);
> +}

Since we're doing a new API, I would prefer to have it as timer_init and
aio_timer_init.  We can remove the allocation completely, it is a
useless indirection and we misuse it since we hardly ever call
qemu_free_timer.

Paolo

>  #endif
>