From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7jdc-0004Eh-Nj for qemu-devel@nongnu.org; Fri, 09 Aug 2013 06:09:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7jdX-0002Et-Ka for qemu-devel@nongnu.org; Fri, 09 Aug 2013 06:09:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7jdX-0002En-Be for qemu-devel@nongnu.org; Fri, 09 Aug 2013 06:09:35 -0400 Message-ID: <5204BFB7.2060105@redhat.com> Date: Fri, 09 Aug 2013 12:08:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1375998147-24292-1-git-send-email-alex@alex.org.uk> <1375998147-24292-17-git-send-email-alex@alex.org.uk> In-Reply-To: <1375998147-24292-17-git-send-email-alex@alex.org.uk> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] [PATCHv8 16/30] aio / timers: On timer modification, qemu_notify or aio_notify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: Kevin Wolf , Anthony Liguori , liu ping fan , qemu-devel@nongnu.org, Stefan Hajnoczi , MORITA Kazutaka , rth@twiddle.net Il 08/08/2013 23:42, Alex Bligh ha scritto: > On qemu_mod_timer_ns, ensure qemu_notify or aio_notify is called to > end the appropriate poll(), irrespective of use_icount value. > > On qemu_clock_enable, ensure qemu_notify or aio_notify is called for > all QEMUTimerLists attached to the QEMUClock. > > Signed-off-by: Alex Bligh Reviewed-by: Paolo Bonzini > --- > include/qemu/timer.h | 9 +++++++++ > qemu-timer.c | 13 ++++++++++--- > 2 files changed, 19 insertions(+), 3 deletions(-) > > diff --git a/include/qemu/timer.h b/include/qemu/timer.h > index 07e6d9e..68f76df 100644 > --- a/include/qemu/timer.h > +++ b/include/qemu/timer.h > @@ -122,6 +122,15 @@ bool qemu_clock_use_for_deadline(QEMUClock *clock); > QEMUTimerList *qemu_clock_get_main_loop_timerlist(QEMUClock *clock); > > /** > + * qemu_clock_nofify: > + * @clock: the clock to operate on > + * > + * Call the notifier callback connected with the default timer > + * list linked to the clock, or qemu_notify() if none. > + */ > +void qemu_clock_notify(QEMUClock *clock); > + > +/** > * timerlist_new: > * @type: the clock type to associate with the timerlist > * > diff --git a/qemu-timer.c b/qemu-timer.c > index 14cb433..4b162e1 100644 > --- a/qemu-timer.c > +++ b/qemu-timer.c > @@ -307,11 +307,20 @@ bool qemu_clock_use_for_deadline(QEMUClock *clock) > return !(use_icount && (clock->type == QEMU_CLOCK_VIRTUAL)); > } > > +void qemu_clock_notify(QEMUClock *clock) > +{ > + QEMUTimerList *timer_list; > + QLIST_FOREACH(timer_list, &clock->timerlists, list) { > + timerlist_notify(timer_list); > + } > +} > + > void qemu_clock_enable(QEMUClock *clock, bool enabled) > { > bool old = clock->enabled; > clock->enabled = enabled; > if (enabled && !old) { > + qemu_clock_notify(clock); > qemu_rearm_alarm_timer(alarm_timer); > } > } > @@ -535,9 +544,7 @@ void qemu_mod_timer_ns(QEMUTimer *ts, int64_t expire_time) > } > /* Interrupt execution to force deadline recalculation. */ > qemu_clock_warp(ts->timer_list->clock); > - if (use_icount) { > - timerlist_notify(ts->timer_list); > - } > + timerlist_notify(ts->timer_list); > } > } > >