From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7jw1-0007Ko-3K for qemu-devel@nongnu.org; Fri, 09 Aug 2013 06:28:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7jvs-0001El-FM for qemu-devel@nongnu.org; Fri, 09 Aug 2013 06:28:41 -0400 Received: from mail-ea0-x231.google.com ([2a00:1450:4013:c01::231]:37793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7jvs-0001ES-8o for qemu-devel@nongnu.org; Fri, 09 Aug 2013 06:28:32 -0400 Received: by mail-ea0-f177.google.com with SMTP id f15so1931761eak.8 for ; Fri, 09 Aug 2013 03:28:31 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5204C42F.6040308@redhat.com> Date: Fri, 09 Aug 2013 12:27:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1375998147-24292-1-git-send-email-alex@alex.org.uk> In-Reply-To: <1375998147-24292-1-git-send-email-alex@alex.org.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] [PATCHv8 00/30] aio / timers: Add AioContext timers and use ppoll List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: Kevin Wolf , Anthony Liguori , qemu-devel@nongnu.org, liu ping fan , Stefan Hajnoczi , MORITA Kazutaka , rth@twiddle.net Il 08/08/2013 23:41, Alex Bligh ha scritto: > This patch series adds support for timers attached to an AioContext clock > which get called within aio_poll. > > In doing so it removes alarm timers and moves to use ppoll where possible. > > This patch set 'sort of' passes make check (see below for caveat) > including a new test harness for the aio timers, but has not been > tested much beyond that. In particular, the win32 changes have not > even been compile tested. Equally, alterations to use_icount > are untested. > > Caveat: I have had to alter tests/test-aio.c so the following error > no longer occurs. > > ERROR:tests/test-aio.c:346:test_wait_event_notifier_noflush: assertion failed: (aio_poll(ctx, false)) > > As gar as I can tell, this check was incorrect, in that it checking > aio_poll makes progress when in fact it should not make progress. I > fixed an issue where aio_poll was (as far as I can tell) wrongly > returning true on a timeout, and that generated this error. > > Note also the comment on patch 18 in relation to a possible bug > in cpus.c. > > The penultimate patch is patch which is created in an automated manner > using scripts/switch-timer-api, added in this patch set. It violates some > coding standards (e.g. line length >= 80 characters), but this is preferable > in terms of giving a provably correct conversion. > > This patch set has been compile tested & make check tested on a > 'christmas-tree' configuration, meaning a configuration with every > --enable- value tested that can be easily configured on Ubuntu Precise, > after application of each patch. Awesome work, really. I think we can still simplify it a bit, but many of the changes I asked should be doable with a global search-and-replace on the patch files. Thanks! Paolo