From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Michael Tsirkin <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pc: drop external DSDT loading
Date: Fri, 09 Aug 2013 15:26:22 +0200 [thread overview]
Message-ID: <5204EDFE.2020302@redhat.com> (raw)
In-Reply-To: <8761vft4xf.fsf@codemonkey.ws>
On 08/09/13 14:38, Anthony Liguori wrote:
> Gerd Hoffmann <kraxel@redhat.com> writes:
>
>> On 08/08/13 18:38, Anthony Liguori wrote:
>>> This breaks migration and is unneeded with modern SeaBIOS.
>>
>> No. Dropping for piix is fine. It will break q35 though.
>
> Can you elaborate? When Michael and I discussed this I was under the
> impression that latest SeaBIOS had full support for q35.
SeaBIOS has the piix acpi tables compiled in, for the snake of backward
compatibility with old qemu versions which don't provide the acpi tables.
With the q35 merge seabios started to provide the apci tables via
fw_cfg, for both q35 and piix, with the long-term goal to drop the
internal tables some day even for piix.
Later on we figured table loading has live migration issues (due to bios
binary being migrated but acpi tables are not, so you can end up with
mismatches).
The idea to deal with that was to simply turn off acpi table loading for
piix4, then wait for mst's acpi table patches which fix this for real
(including migration). Continue loading the tables on q35, ignoring the
live migration issue as ahci renders q35 unmigratable anyway.
I assumed that happend already, but looks like it slipped though,
otherwise you would not have posted that patch ...
cheers,
Gerd
next prev parent reply other threads:[~2013-08-09 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 16:38 [Qemu-devel] [PATCH] pc: drop external DSDT loading Anthony Liguori
2013-08-09 6:48 ` Gerd Hoffmann
2013-08-09 12:38 ` Anthony Liguori
2013-08-09 13:26 ` Gerd Hoffmann [this message]
2013-08-09 15:51 ` Michael S. Tsirkin
2013-08-09 15:50 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204EDFE.2020302@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).