From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44829)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7nes-0005eT-UC
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:27:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7nem-0004xU-UQ
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:27:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10947)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7nem-0004wG-N1
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:27:08 -0400
Message-ID: <5204FC14.6040803@redhat.com>
Date: Fri, 09 Aug 2013 16:26:28 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1375998147-24292-1-git-send-email-alex@alex.org.uk>
	<1375998147-24292-24-git-send-email-alex@alex.org.uk>
	<20130809092335.GE22210@stefanha-thinkpad.redhat.com>
	<F51BE34E-67FC-4324-BA1B-2706F16F1CDB@alex.org.uk>
In-Reply-To: <F51BE34E-67FC-4324-BA1B-2706F16F1CDB@alex.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] [PATCHv8 23/30] aio / timers: Rearrange
 timer.h & make legacy functions call non-legacy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

Il 09/08/2013 16:18, Alex Bligh ha scritto:
> 
> On 9 Aug 2013, at 10:23, Stefan Hajnoczi wrote:
> 
>> On Thu, Aug 08, 2013 at 10:42:20PM +0100, Alex Bligh wrote:
>>> @@ -269,17 +299,17 @@ bool timerlist_expired(QEMUTimerList *timer_list);
>>> int64_t timerlist_deadline_ns(QEMUTimerList *timer_list);
>>>
>>> /**
>>> - * timerlist_getclock:
>>> + * timerlist_get_clock:
>>>  * @timer_list: the timer list to operate on
>>>  *
>>>  * Read the clock value associated with a timer list.
>>>  * The clock value is normally in nanoseconds, but may
>>>  * not be in some instances (e.g. vm_clock with use_icount).
>>
>> The documentation is wrong.  This function does not get the clock value
>> in nanoseconds.
> 
> I will fix.
> 
>>> +/**
>>> + * timer_put:
>>> + * @f: the file
>>> + * @ts: the timer
>>> + */
>>> +void timer_put(QEMUFile *f, QEMUTimer *ts);
>>
>> The struct is still called QEMUTimer, should that also be renamed?
> 
> I could do but it might produce another patch too large for the
> mailing list. Suggest we leave it as it is for now.

Agreed.

Paolo