From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45358)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7nhL-0000Me-9a
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:29:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7nhF-0006FC-9s
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:29:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50372)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7nhF-0006F0-1U
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:29:41 -0400
Message-ID: <5204FCA9.4030305@redhat.com>
Date: Fri, 09 Aug 2013 16:28:57 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1375998147-24292-1-git-send-email-alex@alex.org.uk>
	<1375998147-24292-8-git-send-email-alex@alex.org.uk>
	<5204BE5B.3020308@redhat.com>
	<11C8B4E2-3B4A-4A4E-9FCE-663713D8CE06@alex.org.uk>
In-Reply-To: <11C8B4E2-3B4A-4A4E-9FCE-663713D8CE06@alex.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] [PATCHv8 07/30] aio / timers: Split
 QEMUClock into QEMUClock and QEMUTimerList
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, liu ping fan <qemulist@gmail.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

Il 09/08/2013 16:23, Alex Bligh ha scritto:
> 
> On 9 Aug 2013, at 11:03, Paolo Bonzini wrote:
> 
>>>
>>> +/* New format calling conventions for timers */
>>> +
>>> +/**
>>> + * timer_free:
>>> + * @ts: the timer
>>> + *
>>> + * Free a timer (it must not be on the active list)
>>> + */
>>> +static inline void timer_free(QEMUTimer *ts)
>>> +{
>>> +    qemu_free_timer(ts);
>>> +}
>>
>> If these functions have the same implementation, independent of ts's
>> timerlist, let's just keep the qemu_*_timer names.
> 
> I should probably explain the plan / rationale.
> 
> Either you or Stefan (sorry, can't remember which) mentioned that
> qemu_ as a prefix for functions (as opposed to QEMU as a prefix
> for typedef structs) implied the function operated on a 'global'
> basis. So in keeping with that I'm using qemu_timer_* for the
> global names (i.e. the ones running on mainloop) and timer_*
> for others (currently exactly one user in mainloop).

Yes.  But in this case the mismatch would not hurt, right?

> I want to move away from qemu_*_timer anyway (whether it's
> to qemu_timer_* or timer_*) and indeed the automated patcher
> needs that to be the case, or we can't support both versions
> in the tree at once.
> 
> If we don't want both, I would suggest using timer_* rather
> than qemu_timer_*. This will reduce some of the line wrap
> issues in the automated patch.

Sure.

Paolo