From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47637)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7not-0000mk-T5
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:37:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7non-0000sv-Tf
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:37:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22580)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7non-0000se-LR
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:37:29 -0400
Message-ID: <5204FE82.6080802@redhat.com>
Date: Fri, 09 Aug 2013 16:36:50 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1375998147-24292-1-git-send-email-alex@alex.org.uk>
	<1375998147-24292-14-git-send-email-alex@alex.org.uk>
	<5204BF28.6000800@redhat.com>
	<685383E9-AA6D-4CDC-883B-92229FF601D1@alex.org.uk>
In-Reply-To: <685383E9-AA6D-4CDC-883B-92229FF601D1@alex.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] [PATCHv8 13/30] aio / timers: Add
	aio_timer_new wrapper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, liu ping fan <qemulist@gmail.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

Il 09/08/2013 16:32, Alex Bligh ha scritto:
> 
> On 9 Aug 2013, at 11:06, Paolo Bonzini wrote:
> 
>>> +/**
>>> + * aio_timer_new:
>>> + * @ctx: the aio context
>>> + * @type: the clock type
>>> + * @scale: the scale
>>> + * @cb: the callback to call on timer expiry
>>> + * @opaque: the opaque pointer to pass to the callback
>>> + *
>>> + * Generate a new timer attached to the context @ctx.
>>> + *
>>> + * Returns: a pointer to the new timer
>>> + */
>>> +static inline QEMUTimer *aio_timer_new(AioContext *ctx, QEMUClockType type,
>>> +                                       int scale,
>>> +                                       QEMUTimerCB *cb, void *opaque)
>>> +{
>>> +    return timer_new(ctx->tlg[type], scale, cb, opaque);
>>> +}
>>
>> Since we're doing a new API, I would prefer to have it as timer_init and
>> aio_timer_init.  We can remove the allocation completely, it is a
>> useless indirection and we misuse it since we hardly ever call
>> qemu_free_timer.
> 
> Would that not require change the huge number of qemu_timer_new references
> to use this new API? That sounds less than automatic! Not in favour of
> that one.

qemu_timer_new can remain for now (only waiting for the next
mass-rewriting script to be written).  I would just prefer to have the
new AioContext-/TimerList-aware not do any allocation.

Paolo