From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47807)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7npR-0001aJ-Dx
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:38:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7npL-0001Ia-8a
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:38:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1806)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7npL-0001HK-1V
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:38:03 -0400
Message-ID: <5204FEA3.80109@redhat.com>
Date: Fri, 09 Aug 2013 16:37:23 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1375998147-24292-1-git-send-email-alex@alex.org.uk>
	<1375998147-24292-29-git-send-email-alex@alex.org.uk>
	<5204C3ED.9020800@redhat.com>
	<45B3DE3F-2A03-4A8D-A020-950D74284F9D@alex.org.uk>
In-Reply-To: <45B3DE3F-2A03-4A8D-A020-950D74284F9D@alex.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] [PATCHv8 28/30] aio / timers: Add
	scripts/switch-timer-api
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

Il 09/08/2013 16:35, Alex Bligh ha scritto:
> 
> On 9 Aug 2013, at 11:26, Paolo Bonzini wrote:
> 
>> Il 08/08/2013 23:42, Alex Bligh ha scritto:
>>> +	    # these have just changed name
>>> +	    $line =~ s/\bqemu_mod_timer\b/qemu_timer_mod/g;
>>> +	    $line =~ s/\bqemu_mod_timer_(ns|us|ms)\b/qemu_timer_mod_$1/g;
>>> +	    $line =~ s/\bqemu_free_timer\b/qemu_timer_free/g;
>>> +	    $line =~ s/\bqemu_del_timer\b/qemu_timer_del/g;
>>
>> I couldn't quite track which patch introduced this change.
>>
>> I would either go all the way and drop the qemu_ prefix, or leave the
>> old name in place.
> 
> As per previous comment, they can't stay the same because at various
> stages in the process both apis are used. If we don't want to keep
> qemu_timer_ for the static situation, I suggest we just go to timer_.

Sure.

Paolo