From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51252)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7o3U-0006yL-To
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:52:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7o3O-00076l-Kw
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:52:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32247)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V7o3O-000768-B5
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 10:52:34 -0400
Message-ID: <52050208.2060201@redhat.com>
Date: Fri, 09 Aug 2013 16:51:52 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1375998147-24292-1-git-send-email-alex@alex.org.uk>
	<1375998147-24292-14-git-send-email-alex@alex.org.uk>
	<5204BF28.6000800@redhat.com>
	<685383E9-AA6D-4CDC-883B-92229FF601D1@alex.org.uk>
	<5204FE82.6080802@redhat.com>
	<5F6D944D-F5B9-4A01-9828-8EB3A4B92093@alex.org.uk>
In-Reply-To: <5F6D944D-F5B9-4A01-9828-8EB3A4B92093@alex.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] [PATCHv8 13/30] aio / timers: Add
 aio_timer_new wrapper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, liu ping fan <qemulist@gmail.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

Il 09/08/2013 16:51, Alex Bligh ha scritto:
> 
> On 9 Aug 2013, at 15:36, Paolo Bonzini wrote:
> 
>>> Would that not require change the huge number of qemu_timer_new references
>>> to use this new API? That sounds less than automatic! Not in favour of
>>> that one.
>>
>> qemu_timer_new can remain for now (only waiting for the next
>> mass-rewriting script to be written).  I would just prefer to have the
>> new AioContext-/TimerList-aware not do any allocation.
> 
> One nit:
> 
> Currently struct QEMUTimer lives nicely within qemu_timer.c, hidden
> from the .h, which only contains:
>   typedef struct QEMUTimer QEMUTimer;
> 
> If what you are after is for people to put a QEMUTimer into their
> struct, rather than a QEMUTimer * (and hopefully to remember to
> put qemu_timer_init in!) then I need to move the whole of the
> declaration of the struct to the .h file which is a bit yucky.

Yeah, that's fine.  We're not relying too much on opaque types anyway.

Paolo

> Other than that, fair enough.
>