From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59851)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V8q2e-0005mC-Er
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 07:12:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V8q2Y-0005cU-UG
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 07:12:04 -0400
Received: from cantor2.suse.de ([195.135.220.15]:58388 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V8q2Y-0005cK-O2
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 07:11:58 -0400
Message-ID: <5208C2FA.4010308@suse.de>
Date: Mon, 12 Aug 2013 13:11:54 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1376300525-14950-1-git-send-email-alex@alex.org.uk>
In-Reply-To: <1376300525-14950-1-git-send-email-alex@alex.org.uk>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCHv3] add qemu-img convert -C option (skip
 target volume creation)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Alexandre Derumier <aderumier@odiso.com>

Am 12.08.2013 11:42, schrieb Alex Bligh:
> Add a -C option to skip volume creation on qemu-img convert.
> This is useful for targets such as rbd / ceph, where the
> target volume may already exist; we cannot always rely on
> qemu-img convert to create the image, as dependent on the
> output format, there may be parameters which are not possible
> to specify through the qemu-img convert command line.
>=20
> Code:
>=20
> Author: Alexandre Derumier <aderumier@odiso.com>
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> Signed-off-by: Alex Bligh <alex@alex.org.uk>
>=20
> Documentaton:
>=20
> Author: Alex Bligh <alex@alex.org.uk>
> Signed-off-by: Alex Bligh <alex@alex.org.uk>
> ---

This is a rather odd notation...

The way git-commit works, any committer's Signed-off-by will be placed
directly under the documentation chunk, but it's supposed to cover the
whole commit/patch, not just some aspect of it.

Since as you write, the code is his, the patch should have his From, his
Signed-off-by and finally your Signed-off-by. You can detail your
changes in [AB: ...] or similar between the Signed-off-bys. (To change
the authorship, use git commit --amend --author=3D"Name <email>".)

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg