From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8uRP-00048W-Dl for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:54:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8uRK-0001Rn-Hk for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:53:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8uRK-0001Rb-AB for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:53:50 -0400 Message-ID: <52090505.1010802@redhat.com> Date: Mon, 12 Aug 2013 09:53:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1376233843-19410-1-git-send-email-marcel.a@redhat.com> In-Reply-To: <1376233843-19410-1-git-send-email-marcel.a@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="B1CikIR2Ag6i4px8noM5DBSep0eU1U3mO" Subject: Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: aliguori@us.ibm.com, gleb@redhat.com, mst@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, vrozenfe@redhat.com, pbonzini@redhat.com, afaerber@suse.de, kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --B1CikIR2Ag6i4px8noM5DBSep0eU1U3mO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/11/2013 09:10 AM, Marcel Apfelbaum wrote: > Creating the pvpanic device as part of the machine type has the > potential to trigger guest OS, guest firmware and driver bugs. > The potential of such was originally viewed as minimal. > However, since releasing 1.5 with pvpanic as part > of the builtin machine type, several issues were observed > in the field: > - Some Windows versions triggered 'New Hardware Wizard' and > an unidentified device appeared in Device Manager. > - Issue reported off list: on Linux >=3D 3.10 > the pvpanic driver breaks the reset on crash option: > VM stops instead of being reset. >=20 > pvpanic device also changes monitor command behaviour in some cases, > such silent incompatible changes aren't expected by management tools: > - Monitor command requires 'cont' before 'system_reset' > in order to restart the VM after kernel panic/BSOD=20 >=20 > Note that libvirt is the main user and libvirt people indicated their > preference to creating device with -device pvpanic rather than a > built-in one that can't be removed. >=20 > These issues were raised at last KVM call. The agreement reached > there was that we were a bit too rash to make the device > a builtin, and that for 1.6 we should drop the pvpanic device from the > default machine type, instead teach management tools to add it by > default using -device pvpanic. > It's not clear whether changing 1.5 behaviour at this point > is a sane thing, so this patchset doesn't touch 1.5 machine type. Thanks for doing this; it makes sense to get this in for 1.6. From the libvirt point of view: Series: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --B1CikIR2Ag6i4px8noM5DBSep0eU1U3mO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSCQUFAAoJEKeha0olJ0NqvCYIAIQxqXnzFflS37u4DS2d1xTR sF+ZI6XzXvNfifEcO3OZCG8AA/j7rRNaV5B/poESv7Wnrv0NJwdj9RvLH/XaT+Db NCzq59aizKr36U5hIeCLIEVdnvxN9Ui/0jwDIqapwmvH3Sl+761yqiPqTXEHmz59 5cbY0KBJ2/c15+eWq9fRaDQYR069YUPpHVuEABt023JgPn1ocXB7XdDezE8Nt3zi mrIHHTH1lX4ullcq7F2Z+LZ5Rsj+HCjbqNaPkjxEpcHKB9wF1a+P+E3Pp+aZ7Dxa ZrcAZZ7aK7axpwapZP5XZU94Ouo8RNSBwtcZ6hhFX0tc/u11u2f5hxdwA8/sIuk= =T2FN -----END PGP SIGNATURE----- --B1CikIR2Ag6i4px8noM5DBSep0eU1U3mO--