From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8uVv-0006ps-Qu for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:58:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8uVm-0003Zp-4G for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:58:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8uVl-0003Za-Sm for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:58:26 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7CFwOwu007784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 12 Aug 2013 11:58:24 -0400 Message-ID: <5209061F.10201@redhat.com> Date: Mon, 12 Aug 2013 17:58:23 +0200 From: Michal Novotny MIME-Version: 1.0 References: <0dadf52d6235d364e4e81d6b8b7c8d22ab029bdc.1375254226.git.minovotn@redhat.com> <52090567.4040301@redhat.com> In-Reply-To: <52090567.4040301@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5] vl.c: Output error on invalid machine type provided List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org On 08/12/2013 05:55 PM, Eric Blake wrote: > On 07/31/2013 01:04 AM, Michal Novotny wrote: >> Output error message using qemu's error_report() function when user >> provides the invalid machine type on the command line. This also saves >> time to find what issue is when you downgrade from one version of qemu >> to another that doesn't support required machine type yet (the version >> user downgraded to have to have this patch applied too, of course). >> >> Signed-off-by: Michal Novotny >> --- >> vl.c | 5 +++++ >> 1 file changed, 5 insertions(+) > Are you trying to get this in 1.6? > > Reviewed-by: Eric Blake > It's ok for 1.6. It applies cleanly. So if it's fine with you please push it to the repository. Thanks, Michal -- Michal Novotny , RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org