From: Eric Blake <eblake@redhat.com>
To: Michal Novotny <minovotn@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5] vl.c: Output error on invalid machine type provided
Date: Mon, 12 Aug 2013 10:16:46 -0600 [thread overview]
Message-ID: <52090A6E.1010707@redhat.com> (raw)
In-Reply-To: <5209061F.10201@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1335 bytes --]
On 08/12/2013 09:58 AM, Michal Novotny wrote:
>
> On 08/12/2013 05:55 PM, Eric Blake wrote:
>> On 07/31/2013 01:04 AM, Michal Novotny wrote:
>>> Output error message using qemu's error_report() function when user
>>> provides the invalid machine type on the command line. This also saves
>>> time to find what issue is when you downgrade from one version of qemu
>>> to another that doesn't support required machine type yet (the version
>>> user downgraded to have to have this patch applied too, of course).
>>>
>>> Signed-off-by: Michal Novotny <minovotn@redhat.com>
>>> ---
>>> vl.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>> Are you trying to get this in 1.6?
>>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>
>
> It's ok for 1.6. It applies cleanly. So if it's fine with you please
> push it to the repository.
I'm not the maintainer, so I'm not the one that can push it. At this
phase in the game, it helps if you resend a patch with 'for 1.6' inside
the [] as part of the subject line, as well as cc the maintainer listed
by ./scripts/get_maintainer.pl, to make sure the actual maintainer sees
it and can make a more-informed decision on whether it qualifies as a
bug fix.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
prev parent reply other threads:[~2013-08-12 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 7:04 [Qemu-devel] [PATCH v5] vl.c: Output error on invalid machine type provided Michal Novotny
2013-08-12 15:55 ` Eric Blake
2013-08-12 15:58 ` Michal Novotny
2013-08-12 16:16 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52090A6E.1010707@redhat.com \
--to=eblake@redhat.com \
--cc=minovotn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).