From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8unc-0006mG-Or for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:16:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8unX-0004XF-QP for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:16:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8unX-0004X0-IG for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:16:47 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7CGGkvm015206 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 12 Aug 2013 12:16:47 -0400 Message-ID: <52090A6E.1010707@redhat.com> Date: Mon, 12 Aug 2013 10:16:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <0dadf52d6235d364e4e81d6b8b7c8d22ab029bdc.1375254226.git.minovotn@redhat.com> <52090567.4040301@redhat.com> <5209061F.10201@redhat.com> In-Reply-To: <5209061F.10201@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="84pgXlahH4diJ2P0NR1p9vMuf0xDvHg63" Subject: Re: [Qemu-devel] [PATCH v5] vl.c: Output error on invalid machine type provided List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Novotny Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --84pgXlahH4diJ2P0NR1p9vMuf0xDvHg63 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/12/2013 09:58 AM, Michal Novotny wrote: >=20 > On 08/12/2013 05:55 PM, Eric Blake wrote: >> On 07/31/2013 01:04 AM, Michal Novotny wrote: >>> Output error message using qemu's error_report() function when user >>> provides the invalid machine type on the command line. This also save= s >>> time to find what issue is when you downgrade from one version of qem= u >>> to another that doesn't support required machine type yet (the versio= n >>> user downgraded to have to have this patch applied too, of course). >>> >>> Signed-off-by: Michal Novotny >>> --- >>> vl.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >> Are you trying to get this in 1.6? >> >> Reviewed-by: Eric Blake >> >=20 > It's ok for 1.6. It applies cleanly. So if it's fine with you please > push it to the repository. I'm not the maintainer, so I'm not the one that can push it. At this phase in the game, it helps if you resend a patch with 'for 1.6' inside the [] as part of the subject line, as well as cc the maintainer listed by ./scripts/get_maintainer.pl, to make sure the actual maintainer sees it and can make a more-informed decision on whether it qualifies as a bug fix. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --84pgXlahH4diJ2P0NR1p9vMuf0xDvHg63 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSCQpuAAoJEKeha0olJ0NqXZoH/37PGZX5RLqSRPgJwFWjEnEq pGHaRGhmpJlbpEx0+O5Vko3CW1AlS7yMdKm4BEZL0DCFwGGMi/hdeUJ80vwPtOuz 2OkPzMdqfHLGXBpne05HRryhe94vFZLF52Z6yw9Oi9sda4kcQlWR7dVStUc8zSB/ OAgZUl8yJ1c8Ii5vDYI+v4OIL6W+yZpnUHac25yY0IDNaa7cATmUIRXvE+O28bqC 4HR4D/Opq9glIPjF/vhw6HxIK4iEShg1mGyzpU1S2js4dVtu/lIxjJeEy/2lf6BH VJRx1Qj98wZvnn9QxVxqptQlAAnrRwKVg0ToVtMpAElwK4VjCkJSndwDaS9++0c= =nnh1 -----END PGP SIGNATURE----- --84pgXlahH4diJ2P0NR1p9vMuf0xDvHg63--