From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8vHZ-0007SW-Fz for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:47:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8vHV-0005fY-EU for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:47:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8vHV-0005fB-6i for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:47:45 -0400 Message-ID: <520911AF.4040706@redhat.com> Date: Mon, 12 Aug 2013 10:47:43 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EU9JfXebgijkdbrDPt9gJDLWGOj9SLWot" Subject: Re: [Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Novotny Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EU9JfXebgijkdbrDPt9gJDLWGOj9SLWot Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/12/2013 10:28 AM, Michal Novotny wrote: > Output error message using qemu's error_report() function when user > provides the invalid machine type on the command line. This also saves > time to find what issue is when you downgrade from one version of qemu > to another that doesn't support required machine type yet (the version > user downgraded to have to have this patch applied too, of course). s/have to have/has to have/ >=20 > Signed-off-by: Michal Novotny > --- > vl.c | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Eric Blake (It helps to add a v6 or repost nomenclature in the subject line, when pointing out that this is a repost of a v5 [1]; also, when the patch is unchanged from an already-reviewed earlier version, it is recommended that you amend the message to include Reviewed-by lines carried forward, rather than waiting for reviewers to repeat their comments [2]) [1] https://lists.gnu.org/archive/html/qemu-devel/2013-08/msg01589.html [2] http://wiki.qemu.org/Contribute/SubmitAPatch --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EU9JfXebgijkdbrDPt9gJDLWGOj9SLWot Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSCRGvAAoJEKeha0olJ0NqwBwIALB0uxbDuZVycrfWRAtXVXyw tPasLbIYCIEU12JaNUtyfh6Leoq/hMf1/Xo85c7hRrE3lPSq0D3MqRtYeyh62kbK igWnpCLWDMgO8M8x9lttMAlwqmS+5I8f6CPbw8rvW7Dt15v902jSM4J1l7a34bRa Vk85o1DJznCtRe3P3RFBEoR96Ptmx1jIasqeseeCN+Re7uz5RBR62R4jQuq/60gO l/8u47YP/pfG7zGgw8HfF85D1a55eve/x6lPLp0VfA4aVvgTRl5WfrRAOvB0CY5W /7GfRxrn8tsmbiWhHxPP05AAPA1zifBps6A6gkjRh7AvECwt82TxuBhgF0HtgmI= =bWX0 -----END PGP SIGNATURE----- --EU9JfXebgijkdbrDPt9gJDLWGOj9SLWot--