From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8vIY-000886-4x for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:48:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8vIU-0006At-1d for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:48:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8vIT-0006Ah-Pr for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:48:45 -0400 Message-ID: <520911EB.4020509@redhat.com> Date: Mon, 12 Aug 2013 18:48:43 +0200 From: Michal Novotny MIME-Version: 1.0 References: <520911AF.4040706@redhat.com> In-Reply-To: <520911AF.4040706@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 08/12/2013 06:47 PM, Eric Blake wrote: > On 08/12/2013 10:28 AM, Michal Novotny wrote: >> Output error message using qemu's error_report() function when user >> provides the invalid machine type on the command line. This also saves >> time to find what issue is when you downgrade from one version of qemu >> to another that doesn't support required machine type yet (the version >> user downgraded to have to have this patch applied too, of course). > s/have to have/has to have/ > >> Signed-off-by: Michal Novotny >> --- >> vl.c | 5 +++++ >> 1 file changed, 5 insertions(+) > Reviewed-by: Eric Blake > > (It helps to add a v6 or repost nomenclature in the subject line, when > pointing out that this is a repost of a v5 [1]; also, when the patch is > unchanged from an already-reviewed earlier version, it is recommended > that you amend the message to include Reviewed-by lines carried forward, > rather than waiting for reviewers to repeat their comments [2]) > > [1] https://lists.gnu.org/archive/html/qemu-devel/2013-08/msg01589.html > [2] http://wiki.qemu.org/Contribute/SubmitAPatch Ok, thanks for your feedback and advice Eric :-) Michal > -- Michal Novotny , RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org