From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45415)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1V99yo-0004Cf-Uj
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 04:29:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1V99yj-0000ok-2p
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 04:29:26 -0400
Received: from david.siemens.de ([192.35.17.14]:34623)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1V99yi-0000oe-PD
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 04:29:21 -0400
Message-ID: <5209EE5E.5020100@siemens.com>
Date: Tue, 13 Aug 2013 10:29:18 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1376363741-19420-1-git-send-email-pingfank@linux.vnet.ibm.com>
	<1376363741-19420-4-git-send-email-pingfank@linux.vnet.ibm.com>
	<5209EC20.5060903@siemens.com>
	<CAJnKYQmK1geqDL5OR7r2Vyk2Fi9by4dY1m6JHDj1cSBB54-jOQ@mail.gmail.com>
In-Reply-To: <CAJnKYQmK1geqDL5OR7r2Vyk2Fi9by4dY1m6JHDj1cSBB54-jOQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] slirp: fill mainloop timeout with more
	precise value
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liu ping fan <qemulist@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 2013-08-13 10:25, liu ping fan wrote:
> On Tue, Aug 13, 2013 at 4:19 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2013-08-13 05:15, Liu Ping Fan wrote:
>>> If slirp needs to emulate tcp timeout, then the timeout value
>>> for mainloop should be more precise, which is determined by
>>> slirp's fasttimo or slowtimo.
>>>
>>> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
>>> ---
>>>  main-loop.c   |  2 +-
>>>  slirp/slirp.c | 18 ++++++++++++++++++
>>>  2 files changed, 19 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/main-loop.c b/main-loop.c
>>> index a44fff6..04120d2 100644
>>> --- a/main-loop.c
>>> +++ b/main-loop.c
>>> @@ -458,8 +458,8 @@ int main_loop_wait(int nonblocking)
>>>      g_array_set_size(gpollfds, 0); /* reset for new iteration */
>>>      /* XXX: separate device handlers from system ones */
>>>  #ifdef CONFIG_SLIRP
>>> -    slirp_update_timeout(&timeout);
>>>      slirp_pollfds_fill(gpollfds);
>>> +    slirp_update_timeout(&timeout);
>>
>> Why this reordering?
>>
> In order to give timeout more precise value, which is based on the
> result of fasttimo or slowtimo after slirp_pollfds_fill()

OK. But to avoid that the caller has to know this dependency, better
merge the update timeout logic into pollfds_fill.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux