From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9DN5-0003fn-OX for qemu-devel@nongnu.org; Tue, 13 Aug 2013 08:06:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9DN0-0007QA-SV for qemu-devel@nongnu.org; Tue, 13 Aug 2013 08:06:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9DN0-0007Py-Jz for qemu-devel@nongnu.org; Tue, 13 Aug 2013 08:06:38 -0400 Message-ID: <520A214B.1010703@redhat.com> Date: Tue, 13 Aug 2013 06:06:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1375107465-25767-1-git-send-email-marcel.a@redhat.com> <87mwol29rg.fsf@blackfin.pond.sub.org> In-Reply-To: <87mwol29rg.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jn0Lt2LKF2XAqI3Wt5iKkBoS62haUNfpX" Subject: Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: aliguori@us.ibm.com, mst@redhat.com, Marcel Apfelbaum , qemu-devel@nongnu.org, pbonzini@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jn0Lt2LKF2XAqI3Wt5iKkBoS62haUNfpX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/13/2013 03:57 AM, Markus Armbruster wrote: > This isn't patch review, just a couple of observations and questions. >=20 >=20 > Should we require devices to have at least one category? If they can be enabled from the command line, yes. (Consider '-device pvpanic, which was NOT available in qemu 1.5 because it was unconditional; and for qemu 1.6 which will be conditional in the -M pc-1.6 but unconditional in -M pc-1.5 for back-compat - part of exposing it as conditional in 1.6 was giving it a category). >=20 > Eric, does libvirt still parse -device help? If yes, can it cope with > the addition of "categories ..."? Since qemu 1.3, libvirt has been parsing only QMP commands to learn about device availability (qom-list-types, if I'm not mistaken); -help text is therefore irrelevant, so change away :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jn0Lt2LKF2XAqI3Wt5iKkBoS62haUNfpX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSCiFLAAoJEKeha0olJ0NqtwMH/1lbwE0Tnux32zWJdpA78+My VNMABOOYZvRrgvgLqU8Ibyg2rSEiQ4GNsDOO7DdtkmCp3ryVn8OJi/0ZDCZdOE4L tc3Gsf+V0rBaBYvmlIouU/vU7T2w1dV1TF0+6jnHTj8Ckb9JyZikzQggIbys8OhL +za6YDrls0X7GR+NZt/BM9CiCUyoI7cCpiFbGvOZYgaqf9zqpKMzXaATYmkztJ9s o+hx/sv4H8n483sbFLwwahlMsJq/aEpRzVVyUoiGLu9fCGz4PT7/I+theQEOUx1Z OvnTGo3MzhvB9hJH+HNyfhEf7FgwB5awj0fKwIFZ96L7jIQ4QFkt/AOqCRP/Zdk= =rIyv -----END PGP SIGNATURE----- --jn0Lt2LKF2XAqI3Wt5iKkBoS62haUNfpX--