From: Eric Blake <eblake@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
marcel.a@redhat.com, qemu-devel@nongnu.org,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization
Date: Tue, 13 Aug 2013 07:28:15 -0600 [thread overview]
Message-ID: <520A346F.1070404@redhat.com> (raw)
In-Reply-To: <20130813125349.GA28317@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On 08/13/2013 06:53 AM, Michael S. Tsirkin wrote:
> commit 7f3e341a008c585deed174eaf1f826c88c67948a
> hw/misc: don't create pvpanic device by default
> was mismerged: as a result, pvpanic is enabled in 1.6
>
> Fix this up, clean up a trivial code duplication
> and add a comment explaining why we special-case 1.5
> with respect to pvpanic.
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/i386/pc_piix.c | 6 +++---
> hw/i386/pc_q35.c | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-08-13 13:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 12:53 [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization Michael S. Tsirkin
2013-08-13 13:28 ` Eric Blake [this message]
2013-08-13 14:11 ` Anthony Liguori
2013-08-13 14:54 ` Paolo Bonzini
2013-08-13 15:11 ` Andreas Färber
2013-08-13 15:18 ` Michael S. Tsirkin
2013-08-13 15:27 ` Paolo Bonzini
2013-08-13 15:57 ` Andreas Färber
2013-08-13 16:12 ` Anthony Liguori
2013-08-18 14:46 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A346F.1070404@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).