From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
liu ping fan <qemulist@gmail.com>,
qemu-devel@nongnu.org, Alex Bligh <alex@alex.org.uk>,
MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Subject: Re: [Qemu-devel] [PATCH v2 1/4] seqlock: introduce read-write seqlock
Date: Tue, 13 Aug 2013 16:52:04 +0200 [thread overview]
Message-ID: <520A4814.9070005@redhat.com> (raw)
In-Reply-To: <5209F7C7.7000907@siemens.com>
Il 13/08/2013 11:09, Jan Kiszka ha scritto:
>>>> >>>
>>> >>
>>> >> As the usage pattern is
>>> >>
>>> >> seqlock_read_begin()
>>> >> do
>>> >> ...
>>> >> while (seqlock_read_check())
>>> >>
>>> >> I would suggest to call the latter seqlock_read_retry(), just like the
>>> >> kernel does.
>>> >>
>> > I think it contains the meaning of check-success-or-retry. So may
>> > check be nicer?
> "Check" alone has no obvious semantic for me, therefore "retry".
I agree. I was writing the patch without looking at any Linux code
(just to be safe since it's GPLv2-only) and misremembered the name of
the API.
Paolo
next prev parent reply other threads:[~2013-08-13 14:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 5:43 [Qemu-devel] [PATCH v2 0/4] timers thread-safe stuff Liu Ping Fan
2013-08-13 5:43 ` [Qemu-devel] [PATCH v2 1/4] seqlock: introduce read-write seqlock Liu Ping Fan
2013-08-13 8:26 ` Jan Kiszka
2013-08-13 8:39 ` liu ping fan
2013-08-13 9:09 ` Jan Kiszka
2013-08-13 14:52 ` Paolo Bonzini [this message]
2013-08-13 14:53 ` Jan Kiszka
2013-08-13 15:28 ` Paolo Bonzini
2013-08-13 5:43 ` [Qemu-devel] [PATCH v2 2/4] timer: protect timers_state's clock with seqlock Liu Ping Fan
2013-08-13 5:43 ` [Qemu-devel] [PATCH v2 3/4] qemu-thread: add QemuEvent Liu Ping Fan
2013-08-13 5:43 ` [Qemu-devel] [PATCH v2 4/4] timer: make qemu_clock_enable sync between disable and timer's cb Liu Ping Fan
2013-08-13 14:53 ` Paolo Bonzini
2013-08-14 0:34 ` liu ping fan
2013-08-18 14:54 ` Paolo Bonzini
2013-08-19 7:14 ` liu ping fan
2013-08-19 9:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A4814.9070005@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex@alex.org.uk \
--cc=jan.kiszka@siemens.com \
--cc=kwolf@redhat.com \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).