From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9G0d-0003AG-M1 for qemu-devel@nongnu.org; Tue, 13 Aug 2013 10:55:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9G0V-0005Uw-8l for qemu-devel@nongnu.org; Tue, 13 Aug 2013 10:55:43 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:52383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9G0U-0005Un-PJ for qemu-devel@nongnu.org; Tue, 13 Aug 2013 10:55:34 -0400 Received: by mail-wi0-f169.google.com with SMTP id f14so3078059wiw.4 for ; Tue, 13 Aug 2013 07:55:34 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <520A48C0.5000205@redhat.com> Date: Tue, 13 Aug 2013 16:54:56 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20130813125349.GA28317@redhat.com> <87a9klllyz.fsf@codemonkey.ws> In-Reply-To: <87a9klllyz.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: marcel.a@redhat.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , =?ISO-8859-1?Q?Andreas_F=E4rber?= Il 13/08/2013 16:11, Anthony Liguori ha scritto: >> > Fix this up, clean up a trivial code duplication >> > and add a comment explaining why we special-case 1.5 >> > with respect to pvpanic. >> > >> > Reported-by: Markus Armbruster >> > Signed-off-by: Michael S. Tsirkin > Thanks for catching this. I'm a little disturbed by this. I use git-am > --3way specifically to avoid problems from fuzzing but I guess merge > artifacts are possible. > I wonder if we shouldn't disable pvpanic in 1.5 too, one-off behavior is ugly and likely no one will notice. Paolo