From: "Andreas Färber" <afaerber@suse.de>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, Efimov Vasily <real@ispras.ru>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.
Date: Wed, 14 Aug 2013 13:12:34 +0200 [thread overview]
Message-ID: <520B6622.5020908@suse.de> (raw)
In-Reply-To: <20130814110312.GH4011@smtp.vpn>
Am 14.08.2013 13:03, schrieb Edgar E. Iglesias:
> On Wed, Aug 14, 2013 at 12:03:34PM +0200, Alexander Graf wrote:
>> Then let's make the logic work like this:
>>
>> if (user provided -dtb) {
>> if (load_dtb(user provided dtb)) {
>> abort();
>> }
>> } else {
>> if (load_dtb("ppc.dtb")) {
>> if (load_dtb(find_file(BINARY_DEVICE_TREE_FILE))) {
>> abort();
>> }
>> }
>> }
>
> Hi Alex,
>
> I think that we should only abort() on the -dtb arg case.
Don't abort() on user-supplied arguments, they're for programmer errors.
Also since Alex has been on vacation, please note that we have a shiny
error_report() function that should be preferred over any
fprintf(stderr, ...). :) Only downside is it seems to require its own
#include. :/
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-08-14 11:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 11:09 [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine Efimov Vasily
2013-08-14 9:51 ` Alexander Graf
2013-08-14 9:56 ` Edgar E. Iglesias
2013-08-14 10:03 ` Alexander Graf
2013-08-14 11:03 ` Edgar E. Iglesias
2013-08-14 11:11 ` Alexander Graf
2013-08-14 11:12 ` Andreas Färber [this message]
2013-08-14 10:34 ` Felix Deichmann
2013-08-14 10:38 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520B6622.5020908@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=real@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).