From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43662)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V9Z0S-0003td-6D
	for qemu-devel@nongnu.org; Wed, 14 Aug 2013 07:12:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V9Z0H-0007Id-8b
	for qemu-devel@nongnu.org; Wed, 14 Aug 2013 07:12:48 -0400
Message-ID: <520B6622.5020908@suse.de>
Date: Wed, 14 Aug 2013 13:12:34 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1376392181-30110-1-git-send-email-real@ispras.ru>
	<305EDCD1-E38D-4953-9935-9DAADFFEDD90@suse.de>
	<20130814095643.GG4011@smtp.vpn>
	<6BBCC8BD-4921-43FA-943A-325104B45F24@suse.de>
	<20130814110312.GH4011@smtp.vpn>
In-Reply-To: <20130814110312.GH4011@smtp.vpn>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support
 for this machine.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, Efimov Vasily <real@ispras.ru>, qemu-devel@nongnu.org

Am 14.08.2013 13:03, schrieb Edgar E. Iglesias:
> On Wed, Aug 14, 2013 at 12:03:34PM +0200, Alexander Graf wrote:
>> Then let's make the logic work like this:
>>
>> if (user provided -dtb) {
>>   if (load_dtb(user provided dtb)) {
>>     abort();
>>   }
>> } else {
>>   if (load_dtb("ppc.dtb")) {
>>     if (load_dtb(find_file(BINARY_DEVICE_TREE_FILE))) {
>>       abort();
>>     }
>>   }
>> }
>=20
> Hi Alex,
>=20
> I think that we should only abort() on the -dtb arg case.

Don't abort() on user-supplied arguments, they're for programmer errors.

Also since Alex has been on vacation, please note that we have a shiny
error_report() function that should be preferred over any
fprintf(stderr, ...). :) Only downside is it seems to require its own
#include. :/

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg