From: Laszlo Ersek <lersek@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v4] exec: Fix non-power-of-2 sized accesses
Date: Sat, 17 Aug 2013 11:16:50 +0200 [thread overview]
Message-ID: <520F3F82.10307@redhat.com> (raw)
In-Reply-To: <520F32F9.7080504@redhat.com>
(side point)
On 08/17/13 10:23, Laszlo Ersek wrote:
> if (l >= access_size_max) {
> return access_size_max;
> }
> return 1 << max(3, lmb(l));
lol, of course this should have been min()...
Alex's patch is OK of course.
Laszlo
next prev parent reply other threads:[~2013-08-17 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 21:58 [Qemu-devel] [PATCH v4] exec: Fix non-power-of-2 sized accesses Alex Williamson
2013-08-17 6:33 ` Paolo Bonzini
2013-08-17 15:19 ` Alex Williamson
2013-08-17 8:23 ` Laszlo Ersek
2013-08-17 9:16 ` Laszlo Ersek [this message]
2013-08-17 15:14 ` Alex Williamson
2013-08-17 17:58 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520F3F82.10307@redhat.com \
--to=lersek@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).