From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAdn1-0003rQ-EG for qemu-devel@nongnu.org; Sat, 17 Aug 2013 06:31:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VAdmw-0003Rt-G0 for qemu-devel@nongnu.org; Sat, 17 Aug 2013 06:31:23 -0400 Message-ID: <520F5186.90505@redhat.com> Date: Sat, 17 Aug 2013 12:33:42 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1376651630-9151-1-git-send-email-armbru@redhat.com> <1376651630-9151-5-git-send-email-armbru@redhat.com> In-Reply-To: <1376651630-9151-5-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 4/6] ppc: Don't explode QEMUMachineInitArgs into local variables needlessly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com Cc: aliguori@us.ibm.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, qemu-ppc@nongnu.org, aviksil@linux.vnet.ibm.com On 08/16/13 13:13, armbru@redhat.com wrote: > From: Markus Armbruster > > Don't explode when the variable is used just once, and never changed. > > Signed-off-by: Markus Armbruster > Acked-by: Alexander Graf > --- > hw/ppc/e500plat.c | 18 ++++++------------ > hw/ppc/mpc8544ds.c | 18 ++++++------------ > 2 files changed, 12 insertions(+), 24 deletions(-) Reviewed-by: Laszlo Ersek