qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: aliguori@us.ibm.com, armbru@redhat.com, ehabkost@redhat.com,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup & nicer defaults for type 1
Date: Sat, 17 Aug 2013 06:50:04 -0600	[thread overview]
Message-ID: <520F717C.6040409@redhat.com> (raw)
In-Reply-To: <520F67C9.20807@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

On 08/17/2013 06:08 AM, Laszlo Ersek wrote:
> Eric,
> 
> On 08/16/13 15:18, armbru@redhat.com wrote:
>> From: Markus Armbruster <armbru@redhat.com>
>>
>> This gets rid of one of the last get_param_value() users, makes
>> multiple -smbios work sanely, cleans up the gross side effect in
>> qemu_uuid_parse(), and more.  Topped off with a little feature in the
>> last patch.
>>
>> v2: Rebase, only last patch had conflicts
> 
> can you please re-ack this? You acked v2:
> 
> http://thread.gmane.org/gmane.comp.emulators.qemu/222747

My prior review still stands.  The series looks good to me.

> 
> (And I don't have the slightest clue why it hasn't been merged after
> your Reviewed-by; it was posted, and reviewed, and pinged, before the
> hard freeze for 1.6)

I have no idea what happened either.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

  reply	other threads:[~2013-08-17 12:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16 13:18 [Qemu-devel] [PATCH v2 0/7] smbios cleanup & nicer defaults for type 1 armbru
2013-08-16 13:18 ` [Qemu-devel] [PATCH v2 1/7] smbios: Normalize smbios_entry_add()'s error handling to exit(1) armbru
2013-08-16 13:18 ` [Qemu-devel] [PATCH v2 2/7] smbios: Convert to QemuOpts armbru
2013-09-28 20:47   ` Michael S. Tsirkin
2013-09-30  8:48     ` Markus Armbruster
2013-08-16 13:18 ` [Qemu-devel] [PATCH v2 3/7] smbios: Improve diagnostics for conflicting entries armbru
2013-08-16 13:18 ` [Qemu-devel] [PATCH v2 4/7] smbios: Make multiple -smbios type= accumulate sanely armbru
2013-08-17 12:48   ` Eric Blake
2013-08-16 13:18 ` [Qemu-devel] [PATCH v2 5/7] smbios: Factor out smbios_maybe_add_str() armbru
2013-08-16 13:18 ` [Qemu-devel] [PATCH v2 6/7] vl: Set current_machine early armbru
2013-08-17 13:07   ` Andreas Färber
2013-08-19  9:35     ` Markus Armbruster
2013-08-19 16:37       ` Andreas Färber
2013-08-20  9:09         ` Markus Armbruster
2013-08-16 13:18 ` [Qemu-devel] [PATCH v2 7/7] smbios: Set system manufacturer, product & version by default armbru
2013-08-27 17:04   ` Michael S. Tsirkin
2013-08-27 23:22     ` Eric Blake
2013-08-28  6:05       ` Michael S. Tsirkin
2013-08-17 12:08 ` [Qemu-devel] [PATCH v2 0/7] smbios cleanup & nicer defaults for type 1 Laszlo Ersek
2013-08-17 12:50   ` Eric Blake [this message]
2013-09-17 15:27 ` Michael S. Tsirkin
2013-09-18 11:42   ` Markus Armbruster
2013-09-24  6:07     ` Michael S. Tsirkin
2013-09-28 19:41 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520F717C.6040409@redhat.com \
    --to=eblake@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).