From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAgEk-0007ad-SZ for qemu-devel@nongnu.org; Sat, 17 Aug 2013 09:08:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VAgEd-000759-G2 for qemu-devel@nongnu.org; Sat, 17 Aug 2013 09:08:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54143 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAgEd-00074v-AF for qemu-devel@nongnu.org; Sat, 17 Aug 2013 09:08:03 -0400 Message-ID: <520F75AB.9020904@suse.de> Date: Sat, 17 Aug 2013 15:07:55 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1376659114-6630-1-git-send-email-armbru@redhat.com> <1376659114-6630-7-git-send-email-armbru@redhat.com> In-Reply-To: <1376659114-6630-7-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 6/7] vl: Set current_machine early List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com Cc: aliguori@us.ibm.com, lersek@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com Am 16.08.2013 15:18, schrieb armbru@redhat.com: > From: Markus Armbruster >=20 > I'd like to access QEMUMachine from a QEMUMachine init() method, which > is currently not possible. Instead of passing it as an argument, I > simply set current_machine earlier. We had such a patch for CPU hot-add and decided against doing this. Currently current_machine !=3D signals that it has been initialized. And generally we have been trying to get away from accessing globals from random parts of code. Can't you pass either QEMUMachine or the specific fields needed from PC code to those SMBIOS functions? You did add a bool argument. Andreas >=20 > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > vl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/vl.c b/vl.c > index ba3084c..258e164 100644 > --- a/vl.c > +++ b/vl.c > @@ -3897,6 +3897,7 @@ int main(int argc, char **argv, char **envp) > fprintf(stderr, "No machine found.\n"); > exit(1); > } > + current_machine =3D machine; > =20 > if (machine->hw_version) { > qemu_set_version(machine->hw_version); > @@ -4325,8 +4326,6 @@ int main(int argc, char **argv, char **envp) > =20 > set_numa_modes(); > =20 > - current_machine =3D machine; > - > /* init USB devices */ > if (usb_enabled(false)) { > if (foreach_device_config(DEV_USB, usb_parse) < 0) >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg