From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56282)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1VB9EJ-0006MA-HK
	for qemu-devel@nongnu.org; Sun, 18 Aug 2013 16:05:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1VB9ED-00014b-Vo
	for qemu-devel@nongnu.org; Sun, 18 Aug 2013 16:05:39 -0400
Message-ID: <521128FC.10509@reactos.org>
Date: Sun, 18 Aug 2013 22:05:16 +0200
From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
MIME-Version: 1.0
References: <1376473744-18435-1-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1376473744-18435-1-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.6] adlib: sort offsets in portio
	registration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, aliguori@us.ibm.com, av1474@comtv.ru, qemu-stable@nongnu.org

Ping.

CCing stable too.

Herv=C3=A9

Herv=C3=A9 Poussineau a =C3=A9crit :
> This fixes the following assert when -device adlib is used:
> ioport.c:240: portio_list_add: Assertion `pio->offset >=3D off_last' fa=
iled.
>=20
> Signed-off-by: Herv=C3=A9 Poussineau <hpoussin@reactos.org>
> ---
>  hw/audio/adlib.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c
> index 0421d47..db4a953 100644
> --- a/hw/audio/adlib.c
> +++ b/hw/audio/adlib.c
> @@ -284,9 +284,9 @@ static void Adlib_fini (AdlibState *s)
>  }
> =20
>  static MemoryRegionPortio adlib_portio_list[] =3D {
> -    { 0x388, 4, 1, .read =3D adlib_read, .write =3D adlib_write, },
>      { 0, 4, 1, .read =3D adlib_read, .write =3D adlib_write, },
>      { 0, 2, 1, .read =3D adlib_read, .write =3D adlib_write, },
> +    { 0x388, 4, 1, .read =3D adlib_read, .write =3D adlib_write, },
>      PORTIO_END_OF_LIST(),
>  };
> =20