From: Paolo Bonzini <pbonzini@redhat.com>
To: famz@redhat.com
Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/4] vmdk: fix L1 and L2 table size in vmdk3 open
Date: Mon, 19 Aug 2013 11:29:24 +0200 [thread overview]
Message-ID: <5211E574.1020207@redhat.com> (raw)
In-Reply-To: <20130819021837.GA4427@localhost.localdomain>
Il 19/08/2013 04:18, Fam Zheng ha scritto:
> On Sun, 08/18 17:19, Paolo Bonzini wrote:
>> Il 13/08/2013 03:21, Fam Zheng ha scritto:
>>> VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the
>>> value. This patch honors the header field.
>>>
>>> And the L2 table size is 4096 according to VMDK spec[1], instead of
>>> 1 << 9 (512).
>>
>> I'm not sure from the VMDK spec that _only_ 4096 is supported for VMDK3
>> files. The way I read it, VMDK3 files in hosted products are supposed
>> to have 2K grain tables (as specified by vmdk_open_vmdk3).
>
> I presume "COWD" is only specified in "ESXi Host Sparse Extents"
> section, which is also in practice the only known use case to me. There
> it says "Grain tables have 4096 entries."
>
> I think you meant 2KB grain table specified in section "Hosted Sparse
> Extent Metadata", with 512 entries. If so, it should be for VMDK4 with
> "KDMV" magic bytes, so doesn't affect "COWD".
Ok, thanks for explaining.
Paolo
next prev parent reply other threads:[~2013-08-19 9:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 1:21 [Qemu-devel] [PATCH v2 0/4] vmdk: Support ESX files Fam Zheng
2013-08-13 1:21 ` [Qemu-devel] [PATCH v2 1/4] vmdk: fix L1 and L2 table size in vmdk3 open Fam Zheng
2013-08-18 15:19 ` Paolo Bonzini
2013-08-19 2:18 ` Fam Zheng
2013-08-19 9:29 ` Paolo Bonzini [this message]
2013-08-19 9:53 ` Kevin Wolf
2013-08-13 1:21 ` [Qemu-devel] [PATCH v2 2/4] vmdk: support vmfsSparse files Fam Zheng
2013-08-13 1:21 ` [Qemu-devel] [PATCH v2 3/4] vmdk: support vmfs files Fam Zheng
2013-08-13 1:21 ` [Qemu-devel] [PATCH v2 4/4] vmdk: Move l1_size check into vmdk_add_extent() Fam Zheng
2013-08-19 9:57 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5211E574.1020207@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).