From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48124)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VBLp1-00060r-5t
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 05:32:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VBLov-0004OG-4N
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 05:32:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3524)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VBLou-0004O1-Sq
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 05:32:17 -0400
Message-ID: <5211E5F0.3040304@redhat.com>
Date: Mon, 19 Aug 2013 11:31:28 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1376372630-1983-1-git-send-email-pingfank@linux.vnet.ibm.com>
	<1376372630-1983-5-git-send-email-pingfank@linux.vnet.ibm.com>
	<520A4877.4080202@redhat.com>
	<CAJnKYQ=ydcEE=vcnFoqhNKRjcEDrDTEKO94aLBhcYEVk1pzuJg@mail.gmail.com>
	<5210E011.2010008@redhat.com>
	<CAJnKYQmVmpa635NfF_7kvyQsDUctZJxpQN_9O1sfFKs3evx=xg@mail.gmail.com>
In-Reply-To: <CAJnKYQmVmpa635NfF_7kvyQsDUctZJxpQN_9O1sfFKs3evx=xg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 4/4] timer: make qemu_clock_enable sync
 between disable and timer's cb
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liu ping fan <qemulist@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Alex Bligh <alex@alex.org.uk>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>

Il 19/08/2013 09:14, liu ping fan ha scritto:
>> > But does timerlists need a lock, or does the BQL suffice?  If it
>> > doesn't, there is no need for events_list_lock either.  Is
>> > qemu_clock_enable called outside the BQL?
>> >
> Currently, no such guarantee based on BQL. But if we enforce that an
> backend thread holds BQL before it cleans up resources, we can resort
> to BQL. (so document this, and save the events_list_lock?)

Yes, please.

Paolo