From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBOFS-0006BK-Qz for qemu-devel@nongnu.org; Mon, 19 Aug 2013 08:07:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBOFN-0001wc-RA for qemu-devel@nongnu.org; Mon, 19 Aug 2013 08:07:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBO9Y-0008M6-BM for qemu-devel@nongnu.org; Mon, 19 Aug 2013 08:01:44 -0400 Message-ID: <521208F2.9060009@redhat.com> Date: Mon, 19 Aug 2013 14:00:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <5209E6A1.6060308@siemens.com> <20130813134559.GA29990@stefanha-thinkpad.redhat.com> <520A3EEF.5050509@siemens.com> <520B78C9.1010306@siemens.com> In-Reply-To: <520B78C9.1010306@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Using aio_poll for timer carrier threads List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Kevin Wolf , Anthony Liguori , Alex Bligh , Stefan Hajnoczi , qemu-devel , liu ping fan , Stefan Hajnoczi , MORITA Kazutaka , Richard Henderson Il 14/08/2013 14:32, Jan Kiszka ha scritto: > I still need to check more corner cases as timer dequeuing can now race > with the handler execution, ie. a dequeued timer can still see one more > handler run after timer_del returned. That's a property one can easily > take into account when writing device models, but it has to be kept in > mind that it's different from current behavior. > > Updated queue is at git://git.kiszka.org/qemu.git queues/rt.new3 again. I took a look here, there are several patches that I guess are basically ready... two random things I noticed: (1) rcu_init() must be called in rcutorture too (2) there are several load/store functions in exec.c that do not go through address_space_rw. These would not call qemu_flush_coalesced_mmio_buffer() after your patch "provide address_space_rw_unlocked". I think that in most cases the solution should be to make these functions go through address_space_rw. Paolo