From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-ppc@nongnu.org, Paul Mackerras <paulus@samba.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH 3/8] vfio: Introduce VFIO address spaces
Date: Mon, 19 Aug 2013 15:15:39 +0200 [thread overview]
Message-ID: <52121A7B.6070202@redhat.com> (raw)
In-Reply-To: <1376345257.22121.16.camel@ul30vt.home>
Il 13/08/2013 00:07, Alex Williamson ha scritto:
>> > + if (pci_iommu_as(pdev) != &address_space_memory) {
>> > + error_report("vfio: DMA address space must be system memory");
>> > + return -ENXIO;
> -EFAULT? It's a bad address of sorts.
>
Accessing it would SIGSEGV, so it is not really EFAULT. I would just
use EINVAL, the numeric error code will go away as soon as initfn is
changed to use "Error *" (which is needed to propagate sensible error
messages to the QMP client).
Paolo
next prev parent reply other threads:[~2013-08-19 13:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 8:21 [Qemu-devel] [PATCH 0/8 v3] vfio on power: preparations for VFIO, guest IOMMUs and VFIO itself Alexey Kardashevskiy
2013-08-07 8:21 ` [Qemu-devel] [PATCH 1/8] pci: Introduce helper to retrieve a PCI device's DMA address space Alexey Kardashevskiy
2013-08-07 10:27 ` Michael S. Tsirkin
2013-08-07 8:21 ` [Qemu-devel] [PATCH 2/8] memory: Sanity check that no listeners remain on a destroyed AddressSpace Alexey Kardashevskiy
2013-08-07 8:21 ` [Qemu-devel] [PATCH 3/8] vfio: Introduce VFIO address spaces Alexey Kardashevskiy
2013-08-12 22:07 ` Alex Williamson
2013-08-19 13:15 ` Paolo Bonzini [this message]
2013-08-07 8:21 ` [Qemu-devel] [PATCH 4/8] vfio: Create VFIOAddressSpace objects as needed Alexey Kardashevskiy
2013-08-07 8:21 ` [Qemu-devel] [PATCH 5/8] vfio: Add guest side IOMMU support Alexey Kardashevskiy
2013-08-12 22:07 ` Alex Williamson
2013-08-15 6:02 ` Alexey Kardashevskiy
2013-08-19 13:12 ` Paolo Bonzini
2013-08-21 5:31 ` Alexey Kardashevskiy
2013-08-21 8:55 ` Paolo Bonzini
2013-08-07 8:21 ` [Qemu-devel] [PATCH 6/8] spapr vfio: add vfio_container_spapr_get_info() Alexey Kardashevskiy
2013-08-12 22:07 ` Alex Williamson
2013-08-07 8:21 ` [Qemu-devel] [PATCH 7/8] spapr vfio: add spapr-pci-vfio-host-bridge to support vfio Alexey Kardashevskiy
2013-08-27 11:08 ` Alexander Graf
2013-08-30 7:43 ` Alexey Kardashevskiy
2013-08-30 13:01 ` Andreas Färber
2013-08-07 8:21 ` [Qemu-devel] [PATCH 8/8] spapr vfio: enable for spapr Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52121A7B.6070202@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=mst@redhat.com \
--cc=paulus@samba.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).